Display archived groups when no active groups exist#574
Open
timstott wants to merge 1 commit intooss-apps:mainfrom
Open
Display archived groups when no active groups exist#574timstott wants to merge 1 commit intooss-apps:mainfrom
timstott wants to merge 1 commit intooss-apps:mainfrom
Conversation
krokosik
requested changes
Feb 15, 2026
src/tests/pages/groups.test.tsx
Outdated
| import BalancePage from '~/pages/groups'; | ||
|
|
||
| // Next-i18next – return translation keys as-is | ||
| jest.mock('next-i18next', () => ({ |
Collaborator
There was a problem hiding this comment.
I haven't got the time yet to get into testing Next components, but if it's supposed to look like this, then unfortunately I'm not interested. There must be a saner way to manage all these mocks so as it is readable by a human=. As such, don't worry about tests in your PR and please remove these changes.
Author
There was a problem hiding this comment.
Agreed, it's currently a bit clunky. This can be improved with a wrapper function that mounts the application but the data layer would still need to be mocked/stubeed. What are your thoughts on the testing approach for the project, would you rather see end-to-end tests with something like Cypress or use Jest DOM with an improved interface?
Tests removed ✅ .
0c14040 to
1dfde70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The list of archived groups isn't displayed on the groups page when there are no active groups.
🤖 I’ve added tests to verify that expected elements render correctly in the DOM. I used AI to generate the initial boilerplate, as I’m not yet familiar with writing tests in the Next.js framework. There’s also a question of whether Cypress would be preferable to introduce end-to-end tests for a broader regression prevention.
Demo
Checklist
CONTRIBUTING.mdin its entirety