Skip to content

Display archived groups when no active groups exist#574

Open
timstott wants to merge 1 commit intooss-apps:mainfrom
timstott:fix-display-archived-groups
Open

Display archived groups when no active groups exist#574
timstott wants to merge 1 commit intooss-apps:mainfrom
timstott:fix-display-archived-groups

Conversation

@timstott
Copy link

@timstott timstott commented Feb 13, 2026

Description

The list of archived groups isn't displayed on the groups page when there are no active groups.

🤖 I’ve added tests to verify that expected elements render correctly in the DOM. I used AI to generate the initial boilerplate, as I’m not yet familiar with writing tests in the Next.js framework. There’s also a question of whether Cypress would be preferable to introduce end-to-end tests for a broader regression prevention.

Demo

Before After
Screenshot 2026-02-13 at 08-03-30 Groups Screenshot 2026-02-16 at 07-25-54 Groups

Checklist

  • I have read CONTRIBUTING.md in its entirety
  • I have performed a self-review of my own code
  • I have added unit tests to cover my changes
  • The last commit successfully passed pre-commit checks
  • Any AI code was thoroughly reviewed by me

import BalancePage from '~/pages/groups';

// Next-i18next – return translation keys as-is
jest.mock('next-i18next', () => ({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't got the time yet to get into testing Next components, but if it's supposed to look like this, then unfortunately I'm not interested. There must be a saner way to manage all these mocks so as it is readable by a human=. As such, don't worry about tests in your PR and please remove these changes.

Copy link
Author

@timstott timstott Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, it's currently a bit clunky. This can be improved with a wrapper function that mounts the application but the data layer would still need to be mocked/stubeed. What are your thoughts on the testing approach for the project, would you rather see end-to-end tests with something like Cypress or use Jest DOM with an improved interface?

Tests removed ✅ .

@timstott timstott force-pushed the fix-display-archived-groups branch from 0c14040 to 1dfde70 Compare February 16, 2026 08:04
@timstott timstott requested a review from krokosik February 16, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants