Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was a bit weird, because the decision whether to do full area expire of boundary only is mixed up with the code to do the full area expire. This refactoring fixes that, we decide first what to do and then do it.
What is a bit awkward now is the way we do the box calculation in the decide_expire_mode() function only if needed and then later if it wasn't done already. But if all goes well this will be cleaned up in a future commit when we don't do expire by bounding box any more but by the actual area.