BDD tests: replace sum step with table check with aggregate#2431
Merged
joto merged 1 commit intoosm2pgsql-dev:masterfrom Nov 8, 2025
Merged
BDD tests: replace sum step with table check with aggregate#2431joto merged 1 commit intoosm2pgsql-dev:masterfrom
joto merged 1 commit intoosm2pgsql-dev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not really necessary to define extra steps for table checks with aggregate functions like sum. The "table contains" step can easily handle columns with aggregate functions as long as no "group by" is required. From a testing point of view, the use of aggregate function isn't something to recommend anyway, because it makes debugging failing test difficult and may hide errors.
This replaces the "sum of" step with a "table contains" with aggregates. Sums are only used in the regression tests, which have questionable result checks anyway.