Middle refactor for SQL code#2284
Merged
lonvia merged 9 commits intoosm2pgsql-dev:masterfrom Jan 6, 2025
Merged
Conversation
From the "gen" directory. As preparation for using this code in the main program.
joto
force-pushed
the
middle-prepare
branch
4 times, most recently
from
d75969c to
c1c6538
Compare
It seems superfluous to have all these implementations of the set() function, but there are some problems with MSVC 2019, and this is the workaround. See https://developercommunity.visualstudio.com/t/10242620
Add new middle_pgsql_t::render_template() and middle_pgsql_t::dbexec() functions and use them to create middle tables.
for preparing queries in the middle
Making the code simpler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors in several commits the code creating SQL queries in the middle. There are two reasons for this:
PREPAREto using the special functions of the libpq library (see Create prepared statements via libpq instead of SQL #2118). With this change osm2pgsql should work with setups using load balancers.This is made possible by using a "templating engine" originally created for the generalization code which allows us to write templates of SQL code that are filled in with values for things such as "schema" or "prefix". The first commit moves this code from the "src/gen" directory into "src", futher commits refactor the code step by step.