Skip to content

Conversation

@andordavoti
Copy link

@andordavoti andordavoti commented May 19, 2025

Description

Added full Norwegian (no) translation JSON and integrated it into OryLocales.

Related Issue

No specific issue reported.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
  • If this pull request addresses a security vulnerability, I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2025

⚠️ No Changeset found

Latest commit: 6aed91d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 19, 2025

@andordavoti is attempting to deploy a commit to the ory Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.00%. Comparing base (f3fad4d) to head (117fe7b).
Report is 214 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #544       +/-   ##
===========================================
+ Coverage   42.43%   54.00%   +11.57%     
===========================================
  Files         136      159       +23     
  Lines        2008     2911      +903     
  Branches      288      445      +157     
===========================================
+ Hits          852     1572      +720     
- Misses       1149     1310      +161     
- Partials        7       29       +22     
Components Coverage Δ
@ory/elements-react 52.37% <ø> (+15.58%) ⬆️
@ory/nextjs 62.52% <ø> (-3.46%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thank you!

Just one question.

@andordavoti andordavoti requested a review from jonas-jonas June 17, 2025 15:20
@jonas-jonas
Copy link
Member

Apologies for the delays. I added a few more translations, could you double-check them? Thanks! 117fe7b

If they're good to go, we can merge this right away.

@andordavoti
Copy link
Author

@jonas-jonas can we merge this now?

@jonas-jonas
Copy link
Member

Yes, we're currently changing the process of how open source PRs are being merged, so this is already on its way. This PR will be closed once it's on master. Sorry for all the delays.

@andordavoti
Copy link
Author

Sounds good! Thanks for the PR review:)

@jonas-jonas jonas-jonas closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants