-
Notifications
You must be signed in to change notification settings - Fork 66
docs: clarify use cases and document nextjs #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #490 +/- ##
==========================================
+ Coverage 42.43% 50.21% +7.78%
==========================================
Files 136 153 +17
Lines 2008 2585 +577
Branches 288 387 +99
==========================================
+ Hits 852 1298 +446
- Misses 1149 1266 +117
- Partials 7 21 +14
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A concise documentation update PR clarifying the use cases of the Next.js SDK for Ory by updating package-specific and global README files.
- Updated the Next.js README to include a note on usage for developing custom UI components and configuration details for middleware.
- Clarified the configuration requirements (e.g., NEXT_PUBLIC_ORY_SDK_URL) for local development.
- Added guidance in the global README to direct users toward the Auth.js integration guide if custom UI components are not needed.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/nextjs/README.md | Revised documentation to better clarify the use cases and middleware configuration for both app and page routers. |
| README.md | Updated global instructions for users to follow the Auth.js guide for authentication without UI changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates documentation for the Next.js package and overall repository by clarifying use cases and configuration details.
- In packages/nextjs/README.md, a note and use case section have been added to explain when to use the middleware and how it supports both app and page routers.
- In README.md, guidance for users opting to integrate authentication without altering their UI is provided with a link to the Auth.js guide.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/nextjs/README.md | Expanded documentation with a note, use cases, and configuration info for the middleware. |
| README.md | Added guidance and link for users using Auth.js instead of custom components. |
Needs ory/docs#1730 to be merged