Thin: ensure that errors that occur during fetch are detected

consistently.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -25,11 +25,12 @@ oracledb 1.0.1 (TBD)
 #)  Thin: fixed retry count handling to work in cases where the listener is
     running but the service is down
     (`issue 3 <https://github.com/oracle/python-oracledb/issues/3>`__).
-#)  Thin: if an OS error occurs during the creation of a connection to the
+#)  Thin: if an error occurs during the creation of a connection to the
     database, the error is wrapped by DPY-6005 as an instance of
     oracledb.ConnectionError.
 #)  Fixed issue where unconstrained numbers containing integer values would be
     fetched as floats when oracledb.defaults.fetch_lobs was set to `False`.
+#)  Thin: ensure that errors that occur during fetch are detected consistently.
 
 
 oracledb 1.0.0 (May 2022)

src/oracledb/impl/thin/messages.pyx

@@ -156,6 +156,7 @@ cdef class Message:
         buf.read_ub4(&info.num)             # error number (extended)
         buf.read_ub8(&info.rowcount)        # row number (extended)
         if info.num != 0:
+            self.error_occurred = True
             info.message = buf.read_str(TNS_CS_IMPLICIT).rstrip()
         info.is_warning = False
 
@@ -717,6 +718,7 @@ cdef class MessageWithData(Message):
         if self.error_info.num == TNS_ERR_NO_DATA_FOUND:
             self.error_info.num = 0
             cursor_impl._more_rows_to_fetch = False
+            self.error_occurred = False
         elif self.error_info.num == TNS_ERR_VAR_NOT_IN_SELECT_LIST:
             conn_impl._add_cursor_to_close(cursor_impl._statement)
             cursor_impl._statement._cursor_id = 0

src/oracledb/impl/thin/protocol.pyx

@@ -316,7 +316,6 @@ cdef class Protocol:
         buf.receive_packet(&message.packet_type)
         if message.packet_type == TNS_PACKET_TYPE_MARKER:
             self._reset(message)
-            message.error_occurred = True
         elif message.packet_type == TNS_PACKET_TYPE_REFUSE:
             self._write_buf._packet_sent = False
             buf.skip_raw_bytes(3)