Fixed issue where unconstrained numbers containing integer values would be

fetched as floats when oracledb.defaults.fetch_lobs was set to `False`.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -28,6 +28,8 @@ oracledb 1.0.1 (TBD)
 #)  Thin: if an OS error occurs during the creation of a connection to the
     database, the error is wrapped by DPY-6005 as an instance of
     oracledb.ConnectionError.
+#)  Fixed issue where unconstrained numbers containing integer values would be
+    fetched as floats when oracledb.defaults.fetch_lobs was set to `False`.
 
 
 oracledb 1.0.0 (May 2022)

src/oracledb/impl/base/cursor.pyx

@@ -140,6 +140,7 @@ cdef class BaseCursorImpl:
         """
         cdef:
             BaseVarImpl var_impl
+            uint32_t db_type_num
             object var
 
         # if an output type handler is specified, call it; the output type
@@ -172,19 +173,20 @@ cdef class BaseCursorImpl:
 
         # adjust the variable based on the defaults specified by the user, if
         # applicable
-        if defaults.fetch_decimals and var_impl.dbtype is DB_TYPE_NUMBER:
-            var_impl._preferred_num_type = NUM_TYPE_DECIMAL
+        db_type_num = var_impl.dbtype.num
+        if db_type_num == DB_TYPE_NUM_NUMBER:
+            if defaults.fetch_decimals:
+                var_impl._preferred_num_type = NUM_TYPE_DECIMAL
+            elif var_impl.scale == 0 \
+                    or (var_impl.scale == -127 and var_impl.precision == 0):
+                var_impl._preferred_num_type = NUM_TYPE_INT
         elif not defaults.fetch_lobs:
-            if var_impl.dbtype is DB_TYPE_BLOB:
+            if db_type_num == DB_TYPE_NUM_BLOB:
                 var_impl.dbtype = DB_TYPE_LONG_RAW
-            elif var_impl.dbtype is DB_TYPE_CLOB:
+            elif db_type_num == DB_TYPE_NUM_CLOB:
                 var_impl.dbtype = DB_TYPE_LONG
-            elif var_impl.dbtype is DB_TYPE_NCLOB:
+            elif db_type_num == DB_TYPE_NUM_NCLOB:
                 var_impl.dbtype = DB_TYPE_LONG_NVARCHAR
-        elif var_impl.dbtype is DB_TYPE_NUMBER:
-            if var_impl.scale == 0 \
-                    or (var_impl.scale == -127 and var_impl.precision == 0):
-                var_impl._preferred_num_type = NUM_TYPE_INT
 
         # finalize variable and store in arrays
         var_impl._finalize_init()

tests/test_2200_number_var.py

@@ -464,5 +464,16 @@ def test_2236_out_bind_binary_int_with_large_value(self):
         self.cursor.execute(statement, [simple_var])
         self.assertEqual(simple_var.getvalue(), -2**31 - 1)
 
+    def test_2237_fetch_number_with_lobs_default_false(self):
+        "2237 - fetch a number with oracledb.defaults.fetch_lobs = False"
+        orig_fetch_lobs = oracledb.defaults.fetch_lobs
+        oracledb.defaults.fetch_lobs = False
+        try:
+            self.cursor.execute("select 1 from dual")
+            result, = self.cursor.fetchone()
+            self.assertEqual(type(result), int)
+        finally:
+            oracledb.defaults.fetch_lobs = orig_fetch_lobs
+
 if __name__ == "__main__":
     test_env.run_test_cases()