Fix SyntaxWarning on Python 3.14: move return out of finally blocks#1049
Fix SyntaxWarning on Python 3.14: move return out of finally blocks#1049dylanmtaylor wants to merge 1 commit intooracle:masterfrom
Conversation
Python 3.14 emits SyntaxWarning for return statements inside finally blocks, as they silently swallow exceptions. This moves the return statements out of the finally blocks in list_call_get_all_results and list_call_get_all_results_generator, preserving identical behavior.
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
the
OCA Required
|
Thank you for signing the OCA. |
oracle-contributor-agreement
bot
added
OCA Verified
|
@NiviPari @himanshudas75 I apologize for tagging you on this, but it doesn't seem like this trivial PR is getting any attention. I see you have authorship in this repository. I'd appreciate this being merged in, as every time I use OCI's CLI I'm getting Python warnings. This resolves that without affecting behavior. I have signed the CLA. Thanks! |
1 participant
Python 3.14 warns on
returninsidefinallyblocks. This produces two warnings on every CLI invocation.Moves
return final_responseout of thefinallyblock inlist_call_get_all_resultsandlist_call_get_all_results_generator. Behavior is unchanged.