feat: introduce the Ruff pre-commit hook to replace a bunch of other code formatters and linter hooks#1419
Draft
jenstroeger wants to merge 1 commit into
Draft
feat: introduce the Ruff pre-commit hook to replace a bunch of other code formatters and linter hooks#1419jenstroeger wants to merge 1 commit into
jenstroeger wants to merge 1 commit into
Conversation
…code formatters and linter hooks Signed-off-by: Jens Troeger <jens.troeger@light-speed.de>
Contributor
Author
|
@behnazh-w in addition to the existing checks, perhaps it would make sense to add the following:
Also, note that there’s a macaron/.pre-commit-config.yaml Lines 203 to 211 in 109edd2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change replaces
black,bandit,isort,flake8, andpyupgradegit hooks with a singleruffhook.Description of changes
Ruff is supposed to be a drop-in replacement for the aforementioned checkers, linters, and code formatters and it mostly works. However, it also
FooBarExceptionwhich should be namedFooBarErrorwhich could be considered a breaking change;banditcommentsnosec Bxxxtonoqa: Sxxx.In addition to the rules covering the existing Macaron setup, Ruff provides a bunch of new rules and checkers (e.g. boolean trap) that are probably interesting to add… 🤓
Related issues
n/a
Checklist
verifiedlabel should appear next to all of your commits on GitHub.