update: Updated files for builds for 23c, sqldeveloper, sqlcl, ORDS a…#17
update: Updated files for builds for 23c, sqldeveloper, sqlcl, ORDS a…#17
Conversation
…nd APEX with demo schemas installed
oracle-contributor-agreement
bot
added
the
OCA Verified
gvenzl
left a comment
gvenzl
left a comment
There was a problem hiding this comment.
There are still many 23c references, but that has long been superseded by 26ai. Should we not update this to that?
|
Reviewed 26 changes, removed 23 references. Thanks @gvenzl |
fixed |
gvenzl
left a comment
gvenzl
left a comment
There was a problem hiding this comment.
I found a couple of more things that need a second look.
| @@ -0,0 +1,30 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Should be renamed to installDatabaseFree.sh
| set -x | ||
|
|
||
| . ~oracle/runTimeStartScript.sh | ||
| (/tmp/1/3_2installDatabaseXE_inner.sh "$@" 2>&1) | tee -a ~oracle/log/thestdoutlog_`basename $0`_$$ | egrep '^PROGRESS' |
There was a problem hiding this comment.
should be renamed to ...DatabaseFree_inner.sh
| @@ -0,0 +1,106 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Should be renamed to ...DatabaseFree_inner.sh
|
|
||
| ################################################################################# | ||
| # | ||
| # File: 3_2installDatabaseXE.sh |
| export TWO_TASK= | ||
| ' > /tmp/env1 | ||
| chmod 755 /tmp/env1 | ||
| cp /etc/sysconfig/oracle-xe-18c.conf ~oracle |
| @@ -0,0 +1,57 @@ | |||
|
|
|||
| REM | |||
| REM Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved. | |||
| # Do not change the following system generated value. | ||
| #------------------------------------------------------------------------------- | ||
| oracle.install.responseFileVersion=/oracle/install/rspfmt_dbinstall_response_schema_v18.0.0 | ||
| oracle.install.responseFileVersion=/oracle/install/rspfmt_dbinstall_response_schema_v19.0.0 |
| @@ -0,0 +1,591 @@ | |||
| rem | |||
There was a problem hiding this comment.
wouldn't it be better to pull this from the web and install either the latest or a stable version instead of redistributing?
Just a question, I have nothing against it.
| @@ -1,4 +1,4 @@ | |||
| #!/bin/sh | |||
| bin/sh | |||
There was a problem hiding this comment.
Seems like a typo. It should probably not be there or not have been modified
| 3topLevel.sh PROGRESS: 3/4 3topLevel.sh - main kick off script i.e. yum and call subscripts | ||
| 3_1installDbtoolClientTools.sh PROGRESS: 3_1/4 3_1installDbtoolClientTools.sh - install dbtool client tools | ||
| 3_2installDatabase.sh PROGRESS: 3_2/4 3_2installDatabase.sh - install the database | ||
| 3_2installDatabaseXE.sh PROGRESS: 3_2/4 3_2installDatabaseXE.sh - install the database if XE |
There was a problem hiding this comment.
Should be renamed to ...DatabaseFree etc.
2 participants
Updated files for builds for 23c, sqldeveloper, sqlcl, ORDS a…nd APEX with demo schemas installed