Revert local holdout feature gate logic#637
Merged
muzahidul-opti merged 1 commit intoJun 16, 2026
Merged
Conversation
Remove the FeatureGates.localHoldouts flag and unwrap local holdout evaluation so it runs unconditionally, matching the pre-gate behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
muzahidul-opti
force-pushed
the
muzahidul-opti/enable-local-holdout-feature-gate
branch
from
78e291b to
c2ca71c
Compare
muzahidul-opti
changed the title
raju-opti
approved these changes
Jun 16, 2026
|
|
||
| import Foundation | ||
|
|
||
| struct FeatureGates { |
There was a problem hiding this comment.
can we keep this struct for future reference and just remove the field, maybe add a comment at the top about expected usage?
muzahidul-opti
deleted the
muzahidul-opti/enable-local-holdout-feature-gate
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FeatureGates.localHoldoutsflag fromConstants.swiftDefaultDecisionService.swiftso it runs unconditionallyBaseHoldoutTests.swiftandFeatureGateTests_LocalHoldouts.swiftXCTestCaseproject.pbxprojentries for deleted test filesLocal holdout evaluation no longer needs to be gated behind a feature flag — it should run by default.
Test plan
Issues
🤖 Generated with Claude Code