-
Notifications
You must be signed in to change notification settings - Fork 4
docs: update build performance benchmarks (3.4.1) #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bde928d
docs: update build performance benchmarks (3.4.1)
github-actions[bot] 55992af
Merge branch 'main' into benchmark/build-v3.4.1-20260327-034137
carlos-alm bd2c505
fix(skills): add roadmap ordering cross-check to /release skill
carlos-alm 101a838
Merge branch 'main' into benchmark/build-v3.4.1-20260327-034137
carlos-alm 738ac4e
Merge remote-tracking branch 'origin/benchmark/build-v3.4.1-20260327-…
carlos-alm 28f9e75
fix(docs): restore 3.4.1 raw totals lost in merge, add engine parity …
carlos-alm 22d084d
Merge branch 'main' into benchmark/build-v3.4.1-20260327-034137
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLAUDE.mdis explicit: "Both engines must produce identical results. If they diverge, the less-accurate engine has a bug — fix it, don't document the gap."The 3.4.1 entries reveal a divergence across every parity-sensitive metric:
The 26-node shortfall means the WASM engine is silently missing ~0.24 % of symbols on this codebase. The DB size spread (57,725 vs 42,276 bytes/file) suggests the discrepancy extends beyond just node count into how the schema is populated.
This divergence was already present in 3.4.0 (23.2 vs 23.1 nodes/file, 44.2 vs 44.4 edges/file), so this PR doesn't introduce it — but committing another version's benchmark without a linked issue means the gap will continue to be silently overwritten each release. Per the repo's own policy, the correct path is to:
Context Used: CLAUDE.md (source)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed. Created tracking issue #649 for the native/WASM node count divergence (10,982 vs 10,956) and DB size gap (26.0 MB vs 19.1 MB).
Added an engine parity note in the "Raw totals (latest)" section of BUILD-BENCHMARKS.md that references #649, so future benchmark runs surface the outstanding bug rather than burying it.