Skip to content

move specs/ to dev/specs/#915

Merged
petercrocker merged 2 commits intodevelopfrom
fix/move-specs-to-dev-symlink
Apr 3, 2026
Merged

move specs/ to dev/specs/#915
petercrocker merged 2 commits intodevelopfrom
fix/move-specs-to-dev-symlink

Conversation

@petercrocker
Copy link
Copy Markdown
Contributor

@petercrocker petercrocker commented Apr 3, 2026

  • Chore
    • Reorganized internal specification directory structure across scripts, templates, and documentation to consolidate feature specifications under a dedicated development path.

Context

PR #914 (merge develop → infrahub-develop) has a file/directory conflict: infrahub-develop has specs as a symlink to dev/specs, while develop has it as a real directory. This PR aligns develop with the symlink convention.

Resolves merge conflict with infrahub-develop where specs is a symlink
to dev/specs. Moves spec files to dev/specs/ and creates the symlink so
both branches agree on the structure.
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 3, 2026

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 55788b2
Status: ✅  Deploy successful!
Preview URL: https://5fa6b1e8.infrahub-sdk-python.pages.dev
Branch Preview URL: https://fix-move-specs-to-dev-symlin.infrahub-sdk-python.pages.dev

View logs

@petercrocker petercrocker requested a review from BeArchiTek April 3, 2026 11:22
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2026

Walkthrough

Repository layout assumptions for feature specifications have been updated across multiple files. The primary change relocates the specifications directory structure from specs/ to dev/specs/. Updates include: the bash function get_feature_dir now resolves paths as $1/dev/specs/$2, template files reference the new path structure, documentation paths in .specify/ command files are adjusted to reflect dev/specs/, and existing feature specification documents have their internal path references updated accordingly.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR description provides the why and what, but lacks critical sections like 'How to review', 'How to test', and 'Impact & rollout' details required by the template. Add 'How to review' section identifying key files and risky areas, 'How to test' section with specific validation commands, and 'Impact & rollout' section covering backward compatibility and deployment notes.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The PR title 'move specs/ to dev/specs/' accurately reflects the main change: relocating the specs directory to dev/specs and updating all references throughout the codebase.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ajtmccarty
Copy link
Copy Markdown
Contributor

do we really need both dev/specs and a symlink from spec to dev/specs? can it just be dev/specs?

The symlink from specs/ -> dev/specs/ was redundant. Remove it
and update all path references in templates, scripts, and spec
documents to use dev/specs/ directly.
@petercrocker
Copy link
Copy Markdown
Contributor Author

do we really need both dev/specs and a symlink from spec to dev/specs? can it just be dev/specs?

@ajtmccarty there were quite a few references to /specs already in the repo before I did this, and didn't want to assume. So if we want to clean this up, I've changed all the references in this commit: 55788b2

@petercrocker petercrocker requested a review from a team April 3, 2026 14:58
@petercrocker petercrocker changed the title move specs/ to dev/specs/ and replace with symlink move specs/ to dev/specs/ Apr 3, 2026
@petercrocker petercrocker merged commit a9a6893 into develop Apr 3, 2026
15 checks passed
@petercrocker petercrocker deleted the fix/move-specs-to-dev-symlink branch April 3, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants