Skip to content

security/acme-client: add deploy hook truenas_ws#5309

Merged
fraenki merged 7 commits intoopnsense:masterfrom
sopex:patch-1
Mar 24, 2026
Merged

security/acme-client: add deploy hook truenas_ws#5309
fraenki merged 7 commits intoopnsense:masterfrom
sopex:patch-1

Conversation

@sopex
Copy link
Copy Markdown
Member

@sopex sopex commented Mar 11, 2026

Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:

Related issue
Closes: #5271

@fraenki
Copy link
Copy Markdown
Member

fraenki commented Mar 11, 2026

Is this change backwards-compatible? Will this still work for people that use older versions of TrueNAS Scale, that still use the old API?

@sopex
Copy link
Copy Markdown
Member Author

sopex commented Mar 11, 2026

@fraenki

This is supported since at least TrueNAS Core 12 and all the Scale versions after the merge.
The new websocket api is supported Core 12+ but the particular ACME script does work with 24.10+ only.

It remains a draft because it's not fully validated yet.

For example, it works as a drop-in replacement for 25.10, but potentially for Core 12 you should enable websocket API. (This is a hypothetical)

It remains to be seen, but for the time being, having a truenas old and truenas new does not seem necessary.

I will ping you when it's ready.

@sopex
Copy link
Copy Markdown
Member Author

sopex commented Mar 11, 2026

@fraenki Any concerns or suggestions here?

@sopex sopex marked this pull request as ready for review March 11, 2026 13:17
@fraenki fraenki self-assigned this Mar 17, 2026
@fraenki fraenki changed the title Change deploy hook from truenas to truenas_ws security/acme-client: add deploy hook truenas_ws Mar 17, 2026
@fraenki fraenki added the feature Adding new functionality label Mar 17, 2026
@sopex
Copy link
Copy Markdown
Member Author

sopex commented Mar 24, 2026

merge to make it into 26.1.6? @fraenki
Truenas 26 Beta 2 is fast approaching

@fraenki fraenki merged commit 678a930 into opnsense:master Mar 24, 2026
@sopex
Copy link
Copy Markdown
Member Author

sopex commented Mar 24, 2026

Thank you a lot!

@sopex sopex deleted the patch-1 branch March 24, 2026 16:10
@opnsense opnsense locked as resolved and limited conversation to collaborators Mar 24, 2026
@fraenki
Copy link
Copy Markdown
Member

fraenki commented Mar 24, 2026

Merged, thanks!

There was a minor issue with your submission that was fixed in fe22642.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature Adding new functionality

Development

Successfully merging this pull request may close these issues.

security/acme-client: TrueNAS API deprecation (v26)

2 participants