Global config structure was developed for DynamicQueryAttribute.#45
Open
halilsafakkilic wants to merge 1 commit intooplog:masterfrom
halilsafakkilic:master
Open
Global config structure was developed for DynamicQueryAttribute.#45halilsafakkilic wants to merge 1 commit intooplog:masterfrom halilsafakkilic:master
halilsafakkilic wants to merge 1 commit intooplog:masterfrom
halilsafakkilic:master
Conversation
cyilcode
suggested changes
Sep 14, 2020
|
|
||
| namespace DynamicQueryBuilder | ||
| { | ||
| public static class DynamicQueryAttributeGlobalConfig |
Contributor
There was a problem hiding this comment.
As much as i like the simple development aspect of this static context, this probably will come with its prices like thread safety and all. Instead, i would advise to use dependency injection through the ActionContext and get our settings from there. Here is an example of that.
Edit: Static objects also come with testing challenges since we dont run tests sequentially so if that would create concurrency issues as well.
| public void ShouldNotSetCTorValuesWhenApplyGlobalFilter() | ||
| { | ||
| var defaultInstance = new DynamicQueryAttribute(); | ||
| string queryExceedingMaxCount = DYNAMIC_QUERY_STRING.Replace("count=10", $"count={DynamicQueryAttributeGlobalConfig.MaxCountSize + 1}"); |
Contributor
There was a problem hiding this comment.
As far as i understand we are missing integration tests here. Can we please add those as well ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DynamicQueryAttributeGlobalConfig can be make possible change DynamicQueryAttribute constructor params.