Skip to content

[#435] TodayView에 Coordinator을 구성한다#445

Merged
opficdev merged 4 commits intodevelopfrom
refactor/#435-todayview-coordinator
May 10, 2026
Merged

[#435] TodayView에 Coordinator을 구성한다#445
opficdev merged 4 commits intodevelopfrom
refactor/#435-todayview-coordinator

Conversation

@opficdev
Copy link
Copy Markdown
Owner

🔗 연관된 이슈

📝 작업 내용

📌 요약

TodayView의 ViewModel과 NavigationRouter 소유 책임을 TodayViewCoordinator로 분리

🔍 상세

  • TodayViewCoordinator 추가 및 TodayViewModel, NavigationRouter 소유 이관
  • MainView에서 TodayViewCoordinator를 @State로 보관하도록 구성
  • Today navigation path/detailPath 바인딩을 TodayViewCoordinator의 router 기준으로 정리
  • TodayView의 @State TodayViewModel, @Environment NavigationRouter 의존 제거
  • TodayRoute router를 Environment로 읽는 하위 뷰가 없어 불필요한 environment 주입 제거
  • regular layout에서 Today todo row의 탭 가능 영역 보정

📸 영상 / 이미지 (Optional)

@opficdev opficdev self-assigned this May 10, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Today view by introducing a TodayViewCoordinator to manage its view model and navigation router, decoupling it from the MainViewCoordinator. The feedback suggests replacing a Button with a NavigationLink for list items to improve native interaction feedback and accessibility.

Comment thread DevLog/UI/Today/TodayView.swift
@opficdev opficdev merged commit 273ea71 into develop May 10, 2026
1 check passed
@opficdev opficdev deleted the refactor/#435-todayview-coordinator branch May 10, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TodayView에 Coordinator을 구성한다

1 participant