Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the HomeView architecture by introducing a HomeViewCoordinator to manage view models and routing, decoupling these responsibilities from the MainViewCoordinator. The feedback identifies a redundant @Environment router injection in HomeView that should be removed since the coordinator already provides it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
📝 작업 내용
📌 요약
HomeViewCoordinator추가HomeView의HomeViewModel및 Home 라우터 소유 책임을 coordinator로 분리HomeView의 DIContainer 직접 의존 제거🔍 상세
MainView가HomeViewCoordinator를@State로 소유하도록 구성MainViewCoordinator에서HomeViewModel,homeNavigationRouter제거HomeViewCoordinator에서HomeViewModel,NavigationRouter<HomeRoute>, Home presentation용 ViewModel 생성 책임 관리HomeView는HomeViewCoordinator를 주입받아 상태와 액션을 참조하도록 변경TodoManageViewModel,TodoEditorViewModel,SearchViewModel생성 경로를HomeViewCoordinator로 이동Today,PushNotification,Profilecoordinator 분리는 후속 브랜치 범위로 제외📸 영상 / 이미지 (Optional)