Skip to content

[#414] 앱 쪽 히트맵에서 요일 레이블을 제거한다#429

Merged
opficdev merged 3 commits intodevelopfrom
ui/#414-heatmap
May 5, 2026
Merged

[#414] 앱 쪽 히트맵에서 요일 레이블을 제거한다#429
opficdev merged 3 commits intodevelopfrom
ui/#414-heatmap

Conversation

@opficdev
Copy link
Copy Markdown
Owner

@opficdev opficdev commented May 5, 2026

🔗 연관된 이슈

📝 작업 내용

📌 요약

  • Profile 히트맵 요일 라벨 제거
  • 요일 라벨 제거에 따른 불필요 레이아웃 계산 및 지역화 키 제거

🔍 상세

  • HeatmapView의 요일 라벨 렌더링 경로 제거
  • 요일 라벨 영역 예약용 1컬럼 너비 계산 제거
  • 미사용 profile_weekday_fri, profile_weekday_mon, profile_weekday_wed 지역화 키 제거

📸 영상 / 이미지 (Optional)

@opficdev opficdev self-assigned this May 5, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the weekday labels from the heatmap view and updates the layout logic to distribute the available space among the remaining columns. The feedback suggests simplifying the HeatmapLayout by using weekCounts directly instead of sanitizedWeekCounts to avoid potential logic inconsistencies and unnecessary complexity.

Comment thread DevLog/UI/Profile/HeatmapView.swift
@opficdev opficdev changed the title UI/#414 heatmap [#414] 앱 쪽 히트맵에서 요일 레이블을 제거한다 May 5, 2026
@opficdev opficdev merged commit 40c4d12 into develop May 5, 2026
1 check passed
@opficdev opficdev deleted the ui/#414-heatmap branch May 5, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

앱 쪽 히트맵에서 요일 레이블을 제거한다

1 participant