Fix calculation for the labor items to only allow it for project members#22193
Merged
klaustopher merged 4 commits intorelease/17.2from Mar 5, 2026
Merged
Fix calculation for the labor items to only allow it for project members#22193klaustopher merged 4 commits intorelease/17.2from
klaustopher merged 4 commits intorelease/17.2from
Conversation
klaustopher
force-pushed
the
labor-budgets-calculation-fix
branch
4 times, most recently
from
8ef28be to
3fc0293
Compare
klaustopher
force-pushed
the
labor-budgets-calculation-fix
branch
from
3fc0293 to
aae137d
Compare
klaustopher
commented
Mar 5, 2026
klaustopher
commented
Mar 5, 2026
machisuji
requested changes
Mar 5, 2026
Member
machisuji
left a comment
machisuji
left a comment
There was a problem hiding this comment.
Looks good overall. Although I have one open question about the ids param, and one remark with regards to the specs.
machisuji
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #22163
Also fixes: https://community.openproject.org/wp/72804