[#71653] Sharing of templates

[mrmir]

Ticket

https://community.openproject.org/work_packages/71653

What approach did you choose and why?

• Add a new sharing attribute to Meeting that is an enum with 3 levels corresponding to none, descendants, and system
• Add a class method to see templates visible in a project, which is then used in places that onetime_templates.where(project: @project) was used before
• Add a new onetime template only sidepanel component that allows changing of sharing

Merge checklist

• Added/updated tests
• Added/updated documentation in Lookbook (patterns, previews, etc)
• Tested major browsers (Chrome, Firefox, Edge, ...)

[klaustopher]

I think the enum needs a bit of work. Rest looks fine.

[klaustopher]

Would it make sense to add a validation here in the contract that sharing can only be set on templates?

[klaustopher]

Not a fan of using integer enums. They are brittle and looking just at the DB gives you no knowledge about what is happening. All the other places that have a sharing enum use a string column. It would be better to do this here as well.

Also, I think we should make this column nullable. As we only want sharing on meeting templates.

This is possible in the model:

enum :sharing, { none: "none", project: "project", system: "system" }, validate: { allow_nil: true }

I would even go ahead and add a validation to the model that sharing must be blank, when the meeting is not a template.

[github-actions]

Deploying openproject with ⚡ PullPreview

Field	Value
Latest commit	523598b
Job	deploy
Status	✅ Deploy successful
Preview URL	https://pr-22191-71653-sharing-o-ip-138-201-154-123.my.opf.run:443

View logs