Skip to content

Conversation

@grokspawn
Copy link
Contributor

Description of the change:
syncing the test override mechanism with op-con, based on operator-framework/operator-controller#2431

Motivation for the change:
standardized 'required test override' mechanisms between the repos

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from anik120 and joelanford January 8, 2026 20:44
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.50%. Comparing base (91e49e4) to head (e9117cb).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1874   +/-   ##
=======================================
  Coverage   57.50%   57.50%           
=======================================
  Files         136      136           
  Lines       12934    12934           
=======================================
  Hits         7438     7438           
  Misses       4341     4341           
  Partials     1155     1155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grokspawn grokspawn force-pushed the standardize-test-overrides branch 3 times, most recently from f5b70fd to c9c886a Compare January 12, 2026 22:01
@perdasilva
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2026
Comment on lines 27 to 30
- name: Run go-apidiff
id: check-api
uses: joelanford/go-apidiff@main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need continue-on-error: true here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add this one to operator-controller?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like continue-on-error: true is needed here so the override step can run even if the test fails.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh. I threw this one in this morning, realizing that one of my later PRs was going to need to be able to override go-apidiff. And missed the continue-on-error.
Yes, I think we should also have this in op-con.
Updated.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@rashmigottipati rashmigottipati removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
Signed-off-by: grokspawn <jordan@nimblewidget.com>
@grokspawn grokspawn force-pushed the standardize-test-overrides branch from c9c886a to e9117cb Compare January 13, 2026 23:27
@dtfranz
Copy link
Contributor

dtfranz commented Jan 14, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit b7c3f27 into operator-framework:master Jan 14, 2026
13 checks passed
@grokspawn grokspawn deleted the standardize-test-overrides branch January 14, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants