-
Notifications
You must be signed in to change notification settings - Fork 260
🌱 sync test override pattern with op-con #1874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 sync test override pattern with op-con #1874
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1874 +/- ##
=======================================
Coverage 57.50% 57.50%
=======================================
Files 136 136
Lines 12934 12934
=======================================
Hits 7438 7438
Misses 4341 4341
Partials 1155 1155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f5b70fd to
c9c886a
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| - name: Run go-apidiff | ||
| id: check-api | ||
| uses: joelanford/go-apidiff@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need continue-on-error: true here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add this one to operator-controller?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like continue-on-error: true is needed here so the override step can run even if the test fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argh. I threw this one in this morning, realizing that one of my later PRs was going to need to be able to override go-apidiff. And missed the continue-on-error.
Yes, I think we should also have this in op-con.
Updated.
Signed-off-by: grokspawn <jordan@nimblewidget.com>
c9c886a to
e9117cb
Compare
|
/lgtm |
b7c3f27
into
operator-framework:master
Description of the change:
syncing the test override mechanism with op-con, based on operator-framework/operator-controller#2431
Motivation for the change:
standardized 'required test override' mechanisms between the repos
Reviewer Checklist
/docs