only handle requeue_after if the run is successful#141
Open
gaelgatelement wants to merge 1 commit intooperator-framework:mainfrom
Open
only handle requeue_after if the run is successful#141gaelgatelement wants to merge 1 commit intooperator-framework:mainfrom
gaelgatelement wants to merge 1 commit intooperator-framework:mainfrom
Conversation
Contributor
|
Hi @gaelgatelement sorry for the delay on this, I only work on this in my free time. The extreme nesting of this code makes it very hard to read and isn't very go-idiomatic. Is it possible to:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Handle
nilpresence in the event of failure.Motivation for the change
If there's a fatal error on
requeue_afterfor example due to a wrong call :The controller panics :