Skip to content

chrony: make chrony-hotplug more reliable#28590

Merged
hnyman merged 1 commit intoopenwrt:masterfrom
wagnerflo:master
Mar 15, 2026
Merged

chrony: make chrony-hotplug more reliable#28590
hnyman merged 1 commit intoopenwrt:masterfrom
wagnerflo:master

Conversation

@wagnerflo
Copy link
Copy Markdown
Contributor

At startup there's a race situation where "chronyc waitsync" (and thus chrony-hotplug) will exit right away because it can't bind to loopback.

This change tries quite hard to make chrony-hotplug wait for loopback to come up before running chronyc.

Fixes #28434.

📦 Package Details

Maintainer: @mlichvar
Description:


🧪 Run Testing Details

  • OpenWrt Version: r29103-46f9fc3b71
  • OpenWrt Target/Subtarget: ipq40xx/generic
  • OpenWrt Device: AVM FRITZ!Box 7530

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

@mlichvar
Copy link
Copy Markdown
Contributor

LGTM, thanks!

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Mar 11, 2026

We are missing here Signed-of-by without it, it is not possible to proceed further.

@wagnerflo
Copy link
Copy Markdown
Contributor Author

wagnerflo commented Mar 12, 2026

We are missing here Signed-of-by without it, it is not possible to proceed further.

As I have absolutely no clue about your process here: Is that something I need to do?

@mlichvar
Copy link
Copy Markdown
Contributor

Yes, you need to add your Signed-off-by line to the commit message, e.g. by git commit --amend -s.

At startup there's a race situation where "chronyc waitsync" (and thus
chrony-hotplug) will exit right away because it can't bind to loopback.

This change tries quite hard to make chrony-hotplug wait for loopback to
come up before running chronyc.

Fixes openwrt#28434.

Signed-off-by: Florian Wagner <florian@wagner-flo.de>
@wagnerflo
Copy link
Copy Markdown
Contributor Author

Like this?

@systemcrash
Copy link
Copy Markdown
Contributor

Yes, like that.

@hnyman hnyman merged commit ce52e2e into openwrt:master Mar 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chrony: Hotplug race condition

5 participants