Skip to content

Conversation

@Yang-Wei-Ting
Copy link
Contributor

@Yang-Wei-Ting Yang-Wei-Ting commented Dec 22, 2025

📦 Package Details

Maintainer: @jow-

Description:
Update coreutils to version 9.9.
Drop chcon and runcon as they require SELinux support and cannot be built from coreutils 9.9 when configured with --without-selinux.


🧪 Run Testing Details

  • OpenWrt Version: master
  • OpenWrt Target/Subtarget: Arm SystemReady (EFI) compliant / 64-bit (armv8) machines
  • OpenWrt Device: QEMU

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@Yang-Wei-Ting Yang-Wei-Ting marked this pull request as draft December 22, 2025 14:34
@Yang-Wei-Ting Yang-Wei-Ting marked this pull request as ready for review December 22, 2025 15:55
@Yang-Wei-Ting Yang-Wei-Ting force-pushed the update-coreutils branch 2 times, most recently from 72d92b7 to 757b828 Compare December 24, 2025 11:44
@Yang-Wei-Ting
Copy link
Contributor Author

I wonder why we configure with --without-selinux yet still package chcon and runcon, both of which require SELinux support.

@Yang-Wei-Ting
Copy link
Contributor Author

chcon changes the SELinux security context of the selected files.
runcon runs file in specified SELinux security context.

- Update copyright year.
- Sort DEPENDS lexicographically.
- Switch URL to HTTPS.
- Drop invalid configure option --enable-install-program=su.
  ```
  configure: WARNING: 'su' is not an optionally-installable program
  ```
- Drop unrecognized configure option --with-gmp.
  ```
  configure: WARNING: unrecognized options: --with-gmp
  ```

Signed-off-by: Wei-Ting Yang <williamatcg@gmail.com>
Release notes:
https://lists.gnu.org/archive/html/coreutils-announce/2025-09/msg00000.html
https://lists.gnu.org/archive/html/coreutils-announce/2025-11/msg00000.html

- Drop chcon and runcon as they require SELinux support and cannot be built from
  coreutils 9.9 when configured with --without-selinux.
- Add libgmp dependency for coreutils-basenc to fix missing libgmp.so.10.
- Switch to -std=gnu17 to avoid build failure.
  ```
  lib/openat-die.c: In function 'openat_save_fail':
  lib/openat-die.c:37:3: error: format not a string literal and no format arguments [-Werror=format-security]
     37 |   error (exit_failure, errnum,
        |   ^~~~~
  lib/openat-die.c: In function 'openat_restore_fail':
  lib/openat-die.c:56:3: error: format not a string literal and no format arguments [-Werror=format-security]
     56 |   error (exit_failure, errnum,
        |   ^~~~~
  ```
- Refresh patch.

Signed-off-by: Wei-Ting Yang <williamatcg@gmail.com>
@hnyman hnyman merged commit 3f2fbc8 into openwrt:master Dec 28, 2025
12 checks passed
@Yang-Wei-Ting Yang-Wei-Ting deleted the update-coreutils branch December 28, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants