Skip to content

Conversation

@graysky2
Copy link
Contributor

Remove upstreamed patches and rebase several others. This version build with linux 6.18 but the older one does not.

📦 Package Details

Maintainer: none
(You can find this by checking the history of the package Makefile.)

Description:

This version is needed to build against linux 6.18.

Note I did not run test, only build tested against x86/64-glibc

🧪 Run Testing Details

  • OpenWrt Version: SNAPSHOT
  • OpenWrt Target/Subtarget:
  • OpenWrt Device:

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@graysky2
Copy link
Contributor Author

Banglang Huang is hard-coded as the maintainer but I cannot find this person's github nick. I emailed privately.

@hnyman
Copy link
Contributor

hnyman commented Dec 20, 2025

Just remove the ancient inactive maintainer.
(and put yourself there?)

and CI fails due to dirty patches:

Dirty patches detected, please refresh and review the diff
Error: Process completed with exit code 1.

Apparently several patches need refresh.

@graysky2
Copy link
Contributor Author

I just removed the line all together. Fixed dirty patches (my update script failed to copy them over the first time).

@graysky2 graysky2 force-pushed the libpfring branch 4 times, most recently from 915c837 to 194d3b7 Compare January 1, 2026 12:33
@hnyman
Copy link
Contributor

hnyman commented Jan 2, 2026

Curiously four targets seem to fail, but others succeed. Something about 32bit vs 64 or similar?

@graysky2
Copy link
Contributor Author

graysky2 commented Jan 2, 2026

Copilot:

  1. Fix kernel code type mismatch
    Errors in pf_ring.c like:
    C
    page_end = virt_to_page(base + mem_len - 1);
    should be corrected to cast the address properly:
    C
    page_end = virt_to_page((void *)(base + mem_len - 1));
    and likewise for other virt_to_page or virt_to_pfn calls. Kernel pointer arithmetic must use proper types.

I created this patch. Let's see if effective.

Co-pilot also:

Update your build scripts or Makefiles to detect cross-compilation, and only use -march=native for native builds. For OpenWrt package Makefiles, ensure any CFLAGS/extra compile flags do not use -march=native for cross builds.

@graysky2 graysky2 force-pushed the libpfring branch 2 times, most recently from 9b3fd2a to ce537c2 Compare January 3, 2026 10:24
Bump to 9.2.0 and swtich from git build to tagged tarball.

Added the following patches:
900-Fix-Compilation-on-kernel-6.17.patch (backport)
901-pf_ring-fix-virt_to_page-type-mismatch.patch (pending backport)[1,2]

Removed all upstreamed patches and removed MAINTAINER as no one is
maintaining this pkg. Note that this version is needed in order to
build against linux 6.18.

1. Suggested by CI co-pilot to prevent failure builds for ARM targets
   including: arm_cortex9_vfpv3-d16, arm_cortex-a15_neon-vfpv4,
   powerpc_464fp, and powerpc_8548.

2. ntop/PF_RING#1010

Signed-off-by: John Audia <therealgraysky@proton.me>
@hnyman hnyman merged commit cc4309d into openwrt:master Jan 4, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants