Fix colors on the proctor login page for dark mode. (Bootstrap alert aproach)#2974
Conversation
|
Seems that alerts looking similar might also be an issue on the ProblemSet page or other pages with multiple alerts. My thoughts (Since I requested this) is this approach is preferable, let's stick with the bootstrap colors for consistency vs have some pages use their own. |
|
This isn't really a problem elsewhere. Just because we don't use |
|
I would go with this one. But since @drgrice1 uses the yellow theme, I defer to you if the subtleness is too much of a concern. I'll approve both and let you merge whichever. |
|
I think I also prefer this approach. The subtle difference for the |
The colors for this were inline style. Colors cannot be inline anymore since the server cannot detect if the user will have the browser in dark mode or not. So this switches to using Bootstrap alerts instead.
32e69cb to
2c92b48
Compare
The colors for this were inline style. Colors cannot be inline anymore since the server cannot detect if the user will have the browser in dark mode or not. So this switches to using Bootstrap alerts instead.
This is an alternate approach to #2967.
One minor problem with this approach is that in the

math4-yellowtheme the difference between analert-primaryand analert-warningis somewhat subtle. Here is a screenshot demonstrating the two together with this pull request:The first alert in that image is an
alert-warningand the second is analert-primary.