Open
Conversation
The performance optimization commits introduced three flex layout fast paths that skip child layout when constraints are unchanged: - _hasReusableStableLayoutChain (box_model.dart) - _canSkipAdjustedFlexChildLayout (flex.dart) - _tryNoFlexNoStretchNoBaselineFastPath (flex.dart) - _trySingleFlexibleRunFastPath (flex.dart) All four checked needsRelayout and hasPendingSubtreeIntrinsicMeasurement- Invalidation but omitted hasPendingLayoutUpdate. This flag is set by markNeedsLayout() and cleared only after doLayout() completes. When a DOM mutation (data refresh, tab switch, app backgrounding) triggers markNeedsLayout() on a child whose flex constraints happen not to change, the child was incorrectly skipped — causing it to render stale or blank content until a subsequent layout pass with different constraints forced a full re-layout. Fix: add hasPendingLayoutUpdate guards to all four fast-path sites so that any child dirtied via markNeedsLayout() is always fully laid out, regardless of whether its constraints changed. Also defer display:none→visible widget rebuild notifications that fire while the parent element is temporarily disconnected (tab switch / page refresh), replaying them in connectedCallback() to prevent elements from remaining stuck as SizedBox.shrink().
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.