CVS-187613_fix_c_api_demo#4252
Open
ngrozae wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the c_api_minimal_app demo packaging/extraction flow to use the uncompressed ovms.tar artifact (as produced inside the -pkg image) instead of ovms.tar.gz, aiming to fix the demo build when sourcing artifacts from the Docker packaging image.
Changes:
- Switch
from_dockerextraction in the demo Makefile to retrieveovms.tar(notovms.tar.gz). - Update Ubuntu and Red Hat demo Dockerfiles to
COPY/extractovms.tar.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
demos/c_api_minimal_app/Makefile |
Adjusts Docker-based artifact extraction to use ovms.tar. |
demos/c_api_minimal_app/capi_files/Dockerfile.ubuntu |
Updates demo image build to copy/extract ovms.tar. |
demos/c_api_minimal_app/capi_files/Dockerfile.redhat |
Updates demo image build to copy/extract ovms.tar. |
Comment on lines
45
to
+46
| docker run $(OVMS_CPP_DOCKER_IMAGE)-pkg:$(OVMS_CPP_IMAGE_TAG) bash -c \ | ||
| "tar -c -C /ovms_pkg/$(BASE_OS) ovms.tar.gz ; sleep 2" | tar -x -C capi/$(DIST_OS)/ && cd ../../ | ||
| "tar -c -C /ovms_pkg/$(BASE_OS) ovms.tar ; sleep 2" | tar -x -C capi/$(DIST_OS)/ && cd ../../ |
Comment on lines
+25
to
+26
| COPY ovms.tar / | ||
| RUN tar -xf ovms.tar |
Comment on lines
+22
to
+24
| COPY ovms.tar / | ||
| RUN env | ||
| RUN tar -xf ovms.tar.gz | ||
| RUN tar -xf ovms.tar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CVS-187613 fix c_api_minimal_app demo
🧪 Checklist
``