Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
8c1a0a4
Add lfs curl resume
rasapala Feb 24, 2026
43c8aac
Fix linux build
rasapala Feb 25, 2026
f7e1c85
Git status
rasapala Feb 27, 2026
7dcf659
Works on windows
rasapala Feb 27, 2026
1ea3962
Fix lin
rasapala Feb 27, 2026
3d7a609
Debug
rasapala Mar 2, 2026
417b95c
Blob filter works
rasapala Mar 3, 2026
9841f72
Merge branch 'main' into CVS-175912_git_lfs_resume
rasapala Mar 3, 2026
50b2fcf
Add resume in libgit2 on existing file
rasapala Mar 3, 2026
fdc0309
Fix segfault
rasapala Mar 3, 2026
58f07d0
Find way to set the url
rasapala Mar 3, 2026
acc9098
Set repositroy url
rasapala Mar 4, 2026
ee4462d
Update
rasapala Mar 4, 2026
553458e
Fix file
rasapala Mar 4, 2026
e9b08a7
Force resume
rasapala Mar 4, 2026
1078032
Unit tests for resume
rasapala Mar 5, 2026
7d44981
Fix rename
rasapala Mar 5, 2026
5aae454
Unit test
rasapala Mar 9, 2026
3d8323b
Pass through
rasapala Mar 9, 2026
356dd4e
Lfs upload
rasapala Mar 10, 2026
30072a9
Fix
rasapala Mar 10, 2026
39661c8
Fix 2
rasapala Mar 10, 2026
c2e8e8f
Fix 3
rasapala Mar 10, 2026
ca6e1c1
Working sha
rasapala Mar 10, 2026
110c4e2
Experimentasl cmake off
rasapala Mar 11, 2026
18c37bf
Experimental flag
rasapala Mar 11, 2026
2bae83d
Cleanup
rasapala Mar 11, 2026
ad313b7
Cleanup
rasapala Mar 11, 2026
e55a5a5
Merge branch 'main' into CVS-175912_git_lfs_resume
rasapala Mar 11, 2026
17fcd61
Use VS cmake
rasapala Mar 11, 2026
1041950
Short name
rasapala Mar 11, 2026
5a1d740
Unit tests
rasapala Mar 11, 2026
214161c
Unit tests2
rasapala Mar 12, 2026
78fff02
More tests
rasapala Mar 13, 2026
abacfa8
Style
rasapala Mar 13, 2026
ffa73db
Merge branch 'main' into CVS-175912_git_lfs_resume
rasapala Mar 13, 2026
600d0d8
Resume interval and attemps
rasapala Mar 16, 2026
cebb583
Fix linux compile warnings
rasapala Mar 16, 2026
c46337a
Fix compile 2
rasapala Mar 16, 2026
3f3cc90
Fix compile3
rasapala Mar 16, 2026
9d2bb70
Fix struct
rasapala Mar 17, 2026
ddd90b7
Bug fix
rasapala Mar 17, 2026
ea5613c
Log offset
rasapala Mar 17, 2026
ccb44cc
Fix close
rasapala Mar 17, 2026
c42c661
Fix comment
rasapala Mar 17, 2026
faaabdc
Add comments
rasapala Mar 17, 2026
66d6ab2
Spellings
rasapala Mar 18, 2026
d1614c8
Stdout
rasapala Mar 18, 2026
ce8b04f
Resume ENV tests
rasapala Mar 18, 2026
98ed4ae
Style
rasapala Mar 18, 2026
d64f507
Self review
rasapala Mar 18, 2026
dc8994f
Big memory refactor
rasapala Mar 18, 2026
41cbd8b
Fix unit test
rasapala Mar 19, 2026
fe018f7
Fix unit tests
rasapala Mar 19, 2026
4097632
Fixing tests
rasapala Mar 19, 2026
aa24792
Style
rasapala Mar 19, 2026
35b781f
Fix sporadic segfault
rasapala Mar 19, 2026
10fcec4
Fix version
rasapala Mar 20, 2026
0638f5a
Merge branch 'main' into CVS-175912_git_lfs_resume
rasapala Mar 20, 2026
23ab440
Fix null check
rasapala Mar 20, 2026
8d5539e
Code review
rasapala Mar 20, 2026
97cf90b
Fix style:
rasapala Mar 20, 2026
3b6e36f
Code review2
rasapala Mar 20, 2026
97aa243
Style
rasapala Mar 20, 2026
77644f1
Non blocking and user info with suggestions
rasapala Mar 23, 2026
6f370d1
Style
rasapala Mar 23, 2026
16b5806
Remove max
rasapala Mar 23, 2026
412795a
Merge branch 'main' into CVS-175912_git_lfs_resume
rasapala Mar 23, 2026
75e5310
Refactor fix mem leak
rasapala Mar 23, 2026
6414322
Code review
rasapala Mar 23, 2026
744fc01
Style
rasapala Mar 23, 2026
9b76b8f
Seconds
rasapala Mar 23, 2026
d21473f
Seconds
rasapala Mar 23, 2026
336e1bb
Validate sizes
rasapala Mar 24, 2026
e057514
Fix build
rasapala Mar 24, 2026
75c4339
Data integrity check
rasapala Mar 24, 2026
1211d70
Code review
rasapala Mar 24, 2026
917483d
Code review
rasapala Mar 24, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions src/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2726,6 +2726,7 @@ cc_test(
":network_utils_test",
"//src:custom_nodes_common_buffersqueue",
"@com_google_googletest//:gtest",
":libgit2_test",
":pull_hf_model_test",
":pull_gguf_hf_model_test",
":listdirectorymodels_test",
Expand Down Expand Up @@ -2817,6 +2818,22 @@ cc_library(
linkopts = COMMON_STATIC_LIBS_LINKOPTS,
)


cc_library(
name = "test_file_utils",
linkstatic = 1,
hdrs = [
"test/test_file_utils.hpp",
],
srcs = [
"test/test_file_utils.cpp",
],
deps = [],
local_defines = COMMON_LOCAL_DEFINES,
copts = COPTS_TESTS,
linkopts = COMMON_STATIC_LIBS_LINKOPTS,
)

cc_library(
name = "test_utils",
linkstatic = 1,
Expand Down Expand Up @@ -2960,6 +2977,25 @@ cc_library(
],
copts = COPTS_TESTS,
)
cc_library(
name = "libgit2_test",
linkstatic = 1,
alwayslink = True,
srcs = ["test/libgit2_test.cpp"],
linkopts = [],
deps = [
":test_utils",
":test_file_utils",
":test_platform_utils",
":test_test_models",
":libtest_environment",
"//src:ovms_lib",
"@com_google_googletest//:gtest",
],
local_defines = COMMON_LOCAL_DEFINES,
copts = COPTS_TESTS,
)

cc_library(
name = "pull_hf_model_test",
linkstatic = 1,
Expand All @@ -2970,6 +3006,7 @@ cc_library(
"//src/servables_config_manager_module:listmodels",
"//src/utils:env_guard",
":test_utils",
":test_file_utils",
":libtest_environment",
":test_platform_utils",
":test_test_with_temp_dir",
Expand Down
6 changes: 3 additions & 3 deletions src/pull_module/hf_pull_model_module.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ static std::variant<ovms::Status, Libgit2Options> prepareLibgit2Opts() {
return opts;
}

std::variant<ovms::Status, std::unique_ptr<Libgt2InitGuard>> createGuard() {
std::variant<ovms::Status, std::unique_ptr<Libgt2InitGuard>> createLibGitGuard() {
auto optsOrError = prepareLibgit2Opts();
RETURN_IF_ERROR(optsOrError);
auto initGuard = std::make_unique<Libgt2InitGuard>(std::get<Libgit2Options>(optsOrError));
Expand All @@ -101,7 +101,7 @@ Status HfPullModelModule::start(const ovms::Config& config) {
state = ModuleState::STARTED_INITIALIZE;
SPDLOG_TRACE("{} starting", HF_MODEL_PULL_MODULE_NAME);
if (config.getServerSettings().hfSettings.downloadType == GIT_CLONE_DOWNLOAD) {
auto guardOrError = createGuard();
auto guardOrError = createLibGitGuard();
RETURN_IF_ERROR(guardOrError);
}
this->hfSettings = config.getServerSettings().hfSettings;
Expand All @@ -115,7 +115,7 @@ Status HfPullModelModule::clone() const {
std::unique_ptr<IModelDownloader> downloader;
std::variant<ovms::Status, std::unique_ptr<Libgt2InitGuard>> guardOrError;
if (this->hfSettings.downloadType == GIT_CLONE_DOWNLOAD) {
guardOrError = createGuard();
guardOrError = createLibGitGuard();
if (std::holds_alternative<Status>(guardOrError)) {
return std::get<Status>(guardOrError);
}
Expand Down
4 changes: 3 additions & 1 deletion src/pull_module/hf_pull_model_module.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#include "../capi_frontend/server_settings.hpp"

namespace ovms {

struct Libgt2InitGuard;
class HfPullModelModule : public Module {
protected:
HFSettingsImpl hfSettings;
Expand All @@ -40,4 +40,6 @@ class HfPullModelModule : public Module {
static const std::string GIT_SERVER_TIMEOUT_ENV;
static const std::string GIT_SSL_CERT_LOCATIONS_ENV;
};

std::variant<ovms::Status, std::unique_ptr<Libgt2InitGuard>> createLibGitGuard();
} // namespace ovms
Loading