Remove rank, trust, and pruning_score from runtime and chain state#2565
Open
plind-dm wants to merge 1 commit intoopentensor:devnet-readyfrom
Open
Remove rank, trust, and pruning_score from runtime and chain state#2565plind-dm wants to merge 1 commit intoopentensor:devnet-readyfrom
plind-dm wants to merge 1 commit intoopentensor:devnet-readyfrom
Conversation
Author
|
Hi @sam0x17 @gztensor @JohnReedV @camfairchild 👋 Could one of you approve the CI workflows on this PR? Since it's my first contribution from a fork, the 13 workflows are awaiting manual approval. This PR addresses #2396 — removing Happy to address any feedback. Thanks! |
48d424e to
4475573
Compare
4475573 to
a1258cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fields were removed from epoch computation but their storage reads, writes, and RPC responses remained. This change completes the removal by returning defaults from all getters, stopping genesis/cleanup writes, and marking storage declarations as deprecated.
Closes #2396
Description
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.