improve (async) query map result#266
Merged
thewhaleking merged 5 commits intostagingfrom Feb 13, 2026
Merged
Conversation
…e-retrievable records are the initial batch at instantiation.
ibraheem-abe
approved these changes
Feb 12, 2026
Collaborator
Author
|
Test failures: This is unrelated to the PR, and is related to devnet-ready changing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds
retrieve_all_recordsmethod to (Async)QueryMapResult — basically a convenience method that allows one to "fully exhaust" all pages and have them returned all at once. Whileawait substrate.query_map(fully_exhaust=True)can achieve the same goal for AsyncSubstrateInterface, there's no good method like this for sync, and this doesn't cause a massive gathering, like what would happen in the case offully_exhaust=TrueAdds unit tests