Upgrade watcher-operator to operator-sdk 1.41.1 #308
Conversation
dprince
force-pushed
the
operator_sdk_1.41.1
branch
2 times, most recently
from
d0c6e56 to
4993dee
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/345fbd9e0924490898bf9e97711f376d ❌ openstack-meta-content-provider-master FAILURE in 35m 34s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/407f8f0955ef43ed98e6a78cb820ca85 ❌ openstack-meta-content-provider-master FAILURE in 38m 15s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e52e9342b2fc4556bd8a6c9faffa17c8 ❌ openstack-meta-content-provider-master FAILURE in 36m 46s |
dprince
force-pushed
the
operator_sdk_1.41.1
branch
from
4993dee to
f71e17f
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1a3843b062214fb5962d68f04829ae52 ❌ openstack-meta-content-provider-master FAILURE in 21m 36s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fc8a908a1b0d4b3aa7e327c3367478e0 ❌ openstack-meta-content-provider-master FAILURE in 20m 38s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7169242c9d5248ab8395ba417ae2bb2a ❌ openstack-meta-content-provider-master FAILURE in 18m 54s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/df6a5d9135a64fdbb5214c124346e73a ✔️ openstack-meta-content-provider-master SUCCESS in 2h 52m 37s |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f3018df0ecef4c648e67b9eecf3fb1f3 ✔️ openstack-meta-content-provider-master SUCCESS in 2h 45m 36s |
|
it seems watcher has a similar issue as we had with telemetry. you updated the KUTTL_SUITE_DIR in the makefile from tests to test , but it seems the job is not using the updated one? |
@dprince @stuggi it seems the problem is that we have some watcher-operator/tests/kuttl/test-suites/default/config.yaml Lines 10 to 14 in 363c0c5 |
dprince
force-pushed
the
operator_sdk_1.41.1
branch
from
289e553 to
49918c7
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/46557ffefe1d404e931737428104409d ✔️ openstack-meta-content-provider-master SUCCESS in 2h 37m 25s |
|
recheck |
|
/lgtm |
dprince
force-pushed
the
operator_sdk_1.41.1
branch
from
49918c7 to
b011619
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c712188de06c4ed4a0ae408bf7369e32 ✔️ openstack-meta-content-provider-master SUCCESS in 1h 05m 19s |
dprince
force-pushed
the
operator_sdk_1.41.1
branch
3 times, most recently
from
fee54d2 to
0f7c113
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/df00c10f90924087bd902703ee676c5a ✔️ openstack-meta-content-provider-master SUCCESS in 2h 50m 56s |
dprince
force-pushed
the
operator_sdk_1.41.1
branch
from
0f7c113 to
bfb5c6a
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f3688bea12d744849ffb6a62e9e8937e ✔️ openstack-meta-content-provider-master SUCCESS in 2h 44m 18s |
dprince
force-pushed
the
operator_sdk_1.41.1
branch
from
bfb5c6a to
a03c42d
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/07810a9a0f2a4bb790dc7e8dbd75c20e ✔️ openstack-meta-content-provider-master SUCCESS in 2h 47m 19s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5ba36b4f3e964e51afe593e50da7245a ✔️ openstack-meta-content-provider-master SUCCESS in 2h 39m 35s |
hack/stop_integrated_watcher.sh
Outdated
| oc wait --for=jsonpath='{.spec.replicas}'=0 deploy/openstack-operator-controller-operator -n openstack-operators --timeout=60s | ||
| oc wait --for=jsonpath='{.status.replicas}'=0 deploy/openstack-operator-controller-operator -n openstack-operators --timeout=60s |
There was a problem hiding this comment.
The result of this is strange:
+ oc patch clusterserviceversion.operators.coreos.com/openstack-operator.v0.5.0 -n openstack-operators --type=json '-p=[{'\''op'\'': '\''replace'\'', '\''path'\'': '\''/spec/install/spec/deployments/0/spec/replicas'\'', '\''value'\'': 0}]'
clusterserviceversion.operators.coreos.com/openstack-operator.v0.5.0 patched
+ oc wait '--for=jsonpath={.spec.replicas}=0' deploy/openstack-operator-controller-operator -n openstack-operators --timeout=60s
deployment.apps/openstack-operator-controller-operator condition met
+ oc wait '--for=jsonpath={.status.replicas}=0' deploy/openstack-operator-controller-operator -n openstack-operators --timeout=60s
error: timed out waiting for the condition on deployments/openstack-operator-controller-operator
+ oc scale --replicas=0 -n openstack-operators deploy/watcher-operator-controller-manager
deployment.apps/watcher-operator-controller-manager scaled
+ oc wait '--for=jsonpath={.spec.replicas}=0' deploy/watcher-operator-controller-manager -n openstack-operators --timeout=60s
deployment.apps/watcher-operator-controller-manager condition met
+ oc wait '--for=jsonpath={.status.replicas}=0' deploy/watcher-operator-controller-manager -n openstack-operators --timeout=60s
error: timed out waiting for the condition on deployments/watcher-operator-controller-manager
So, it seems that the first oc wait succeed deployment.apps/openstack-operator-controller-operator condition met and the second timeouts error: timed out waiting for the condition on deployments/openstack-operator-controller-operator and same for the watcher-operator.
Note that in the final logs, there are no pods for both openstack controller-operator or watcher-operator https://logserver.rdoproject.org/0b4/rdoproject.org/0b40d629a35c491c95c92c04173c48a8/controller/ci-framework-data/logs/openstack-must-gather/quay-io-openstack-k8s-operators-openstack-must-gather-sha256-854a802357b4f565a366fce3bf29b20c1b768ec4ab7e822ef52dfc2fef000d2c/namespaces/openstack-operators/pods/
There was a problem hiding this comment.
now it looks good. new operator from the PR was deployed
env:
- name: RELATED_IMAGE_WATCHER_API_IMAGE_URL_DEFAULT
value: 38.102.83.2:5001/podified-master-centos10/openstack-watcher-api:watcher_latest
- name: RELATED_IMAGE_WATCHER_DECISION_ENGINE_IMAGE_URL_DEFAULT
value: 38.102.83.2:5001/podified-master-centos10/openstack-watcher-decision-engine:watcher_latest
- name: RELATED_IMAGE_WATCHER_APPLIER_IMAGE_URL_DEFAULT
value: 38.102.83.2:5001/podified-master-centos10/openstack-watcher-applier:watcher_latest
- name: OPERATOR_CONDITION_NAME
value: watcher-operator.v0.0.1
image: 38.102.83.2:5001/openstack-k8s-operators/watcher-operator:0e562967e0a192baf562500f49cef0abd8c6f6ec
3f4d014 to
04f2b75
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1c54273db272446da5b02f38ebb51eeb ✔️ openstack-meta-content-provider-master SUCCESS in 2h 33m 56s |
Rescaffold the watcher-operator to operator-sdk 1.41.1, which includes: - Reorganize project structure (pkg/ -> internal/) - Move webhook implementations to internal/webhook/v1beta1/ - Add new cmd/main.go entrypoint with updated controller initialization - Update RBAC, certmanager, and prometheus configurations - Enhance network policies for metrics and webhook traffic - Set watcher as defaulting resource in PROJECT file - Remove auto-generated test suite scaffolding - Update build workflow and Dockerfile to version 1.41.1 This upgrade modernizes the operator structure and aligns with the latest operator-sdk best practices. Jira: OSPRH-22014 Depends-On: openstack-k8s-operators/openstack-operator#1683
dprince
force-pushed
the
operator_sdk_1.41.1
branch
from
04f2b75 to
0e56296
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d5ceed87f86a496187bc0d4b9d410127 ✔️ openstack-meta-content-provider-master SUCCESS in 1h 24m 51s |
|
recheck |
Depends-On: openstack-k8s-operators#308 Depends-On: openstack-k8s-operators/ci-framework#3526 Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
Depends-On: openstack-k8s-operators#308 Depends-On: openstack-k8s-operators/ci-framework#3526 Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
Depends-On: openstack-k8s-operators#308 Depends-On: openstack-k8s-operators/ci-framework#3526 Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amoralej The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4ee3efe
into
openstack-k8s-operators:main
Depends-On: openstack-k8s-operators#308 Depends-On: openstack-k8s-operators/ci-framework#3526 Signed-off-by: Chandan Kumar (raukadah) <raukadah@gmail.com>
5 participants
Rescaffold the watcher-operator to operator-sdk 1.41.1, which includes:
This upgrade modernizes the operator structure and aligns with the latest operator-sdk best practices.
Jira: OSPRH-22014
Depends-On: openstack-k8s-operators/openstack-operator#1683