-
Notifications
You must be signed in to change notification settings - Fork 50
[18.0-fr4] [OSPRH-21020] Scrape all rabbitmq pods #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0-fr4] [OSPRH-21020] Scrape all rabbitmq pods #816
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bbe6663510cb41b195662779e0f9b83a ❌ openstack-k8s-operators-content-provider FAILURE in 7m 02s |
RabbitMQ can be deployed with multiple replicas, while each replica will export different metrics. Having a ScrapeConfig with a service as a target means we're not scraping all metrics. This PR uses the Endpoints object to retrieve IP addresses of all rabbitmq related pods and creates a ScrapeConfig to scrape each pod through its IP address. This keeps the pattern of using ScrapeConfigs for configuring scraping. Cherry-pick from: openstack-k8s-operators#780
543ae92 to
95f5467
Compare
|
/retest |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/20b680295e5a4e748e7037d6a48729ad ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 39s |
|
recheck issue with edpm-ansible on FR4 should be fixed now |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ab13ebf1837e4be99ffc5aea309906d3 ✔️ openstack-k8s-operators-content-provider SUCCESS in 59m 44s |
|
recheck keystone failure |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ab465232f85c4c079be2f762430c557e ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 02m 25s |
|
recheck openstack sub creation failure |
|
/retest |
|
/lgtm |
dad41e4
into
openstack-k8s-operators:18.0-fr4
RabbitMQ can be deployed with multiple replicas, while each replica will export different metrics. Having a ScrapeConfig with a service as a target means we're not scraping all metrics. This PR uses the Endpoints object to retrieve IP addresses of all rabbitmq related pods and creates a ScrapeConfig to scrape each pod through its IP address. This keeps the pattern of using ScrapeConfigs for configuring scraping.
Cherry-pick from: #780