Application Credential support #364
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Deydra71 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Deydra71
force-pushed
the
appcred-support
branch
from
6c8e2ac to
09e4eb3
Compare
Deydra71
force-pushed
the
appcred-support
branch
from
09e4eb3 to
2e641c2
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
mrkisaolamb
left a comment
mrkisaolamb
left a comment
There was a problem hiding this comment.
Other than these small comments, everything looks good. So once we land the keystone-operator changes, we should be ready to go with this patch as well. I don't see any issues with the update/upgrade path. The only thing worth adding might be a kuttl test with the new secret
| DEFAULT_IMG ?= quay.io/openstack-k8s-operators/placement-operator:latest | ||
| IMG ?= $(DEFAULT_IMG) | ||
| # ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary. | ||
| ENVTEST_K8S_VERSION = 1.31 |
There was a problem hiding this comment.
why we downgrade this requirements?
There was a problem hiding this comment.
Thanks for catching this! Probably an old remnant of local testing..
| conf := configSecret.Data["placement.conf"] | ||
|
|
||
| Expect(conf).To(ContainSubstring("application_credential_id = test-ac-id")) | ||
| Expect(conf).To(ContainSubstring("application_credential_secret = test-ac-secret")) |
There was a problem hiding this comment.
please add also negative assert for username, password etc, also to be sure that we cover all changes in conf we should also assert auth_type
Deydra71
force-pushed
the
appcred-support
branch
from
2e641c2 to
2ca02e9
Compare
Adds the end-to-end support for consuming Keystone ApplicationCredentials (AC) in the Placement operator, enabling Placement pod to use AC-based authentication when available. Signed-off-by: Veronika Fisarova <vfisarov@redhat.com>
Deydra71
force-pushed
the
appcred-support
branch
from
2ca02e9 to
0cd688b
Compare
|
@Deydra71: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Jira: OSPRH-16629
Adds the end-to-end support for consuming Keystone ApplicationCredentials (AC) in the Placement operator, enabling Placement pods to use AC-based authentication when available.
Depends-On: openstack-k8s-operators/keystone-operator#567