Skip to content

Add validation webhooks for service operators #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jun 3, 2024
Merged

Add validation webhooks for service operators #791

openshift-merge-bot merged 1 commit into from
Jun 3, 2024

Conversation

@stuggi
Copy link
Contributor

@stuggi stuggi commented May 7, 2024 •
edited
Loading

@openshift-ci openshift-ci bot requested review from abays and dprince May 7, 2024 14:18
@stuggi
Copy link
Contributor Author

stuggi commented May 7, 2024

/hold

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented May 7, 2024

This change depends on a change that failed to merge.

Change openstack-k8s-operators/keystone-operator#414 is needed.

@stuggi stuggi force-pushed the endpoint_webhook branch from b090408 to 8f1bffd Compare May 14, 2024 05:53
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented May 14, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a73448f22fae449b9902c932ffd74e3f

❌ openstack-k8s-operators-content-provider FAILURE in 18m 12s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@stuggi stuggi force-pushed the endpoint_webhook branch from 8f1bffd to fc8d0cd Compare May 23, 2024 12:28
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented May 23, 2024

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 791,fc8d0cd7e4ede9ebaa68c26f44f3ed20bdb8e0b7

@stuggi stuggi force-pushed the endpoint_webhook branch from fc8d0cd to 231c48b Compare May 23, 2024 12:30
@stuggi stuggi changed the title Add validation webhooks for keystone Add validation webhooks for service operators May 23, 2024
@stuggi stuggi force-pushed the endpoint_webhook branch from 231c48b to e93f1c0 Compare May 24, 2024 12:09
@stuggi stuggi requested a review from olliewalsh May 24, 2024 12:15
@stuggi stuggi force-pushed the endpoint_webhook branch from e93f1c0 to 03d9852 Compare June 3, 2024 05:51
@stuggi stuggi force-pushed the endpoint_webhook branch from 03d9852 to c3916c9 Compare June 3, 2024 08:42
abays
abays approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 3, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fb5ce90 into openstack-k8s-operators:main Jun 3, 2024
cjeanner pushed a commit to cjeanner/openstack-operator that referenced this pull request Apr 9, 2025
@openshift-merge-bot
Merge pull request openstack-k8s-operators#791 from auniyal61/doc-update
f69a0d8 
Doc-Update: replace hugepages1g to hugepages1G
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abays abays abays approved these changes

@dprince dprince Awaiting requested review from dprince

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

Assignees

@abays abays

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stuggi @abays @openshift-merge-robot