Skip to content

Inform developer how to restore OLM CSV after cleanup with local webhook#1919

Open
ciecierski wants to merge 1 commit into
openstack-k8s-operators:mainfrom
ciecierski:cleanup-message
Open

Inform developer how to restore OLM CSV after cleanup with local webhook#1919
ciecierski wants to merge 1 commit into
openstack-k8s-operators:mainfrom
ciecierski:cleanup-message

Conversation

@ciecierski
Copy link
Copy Markdown
Contributor

@ciecierski ciecierski commented May 14, 2026

Print a message in the cleanup handler with the exact oc patch command needed to restore the operator's original CSV after the local webhook run exits.

@openshift-ci openshift-ci Bot requested review from fultonj and rebtoor May 14, 2026 11:40
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026 •
edited
Loading

OpenStackControlPlane CRD Size Report

Metric Value
CRD JSON size 322464 bytes (315KB)
Base branch size 322464 bytes
Change +0.00%
Status yellow — growing
Threshold reference
Color Range Meaning
🟢 green < 300KB Comfortable
🟡 yellow 300–400KB Growing
🟠 orange 400–750KB Concerning
🔴 red > 750KB Approaching 1.5MB etcd limit (cut in half to allow space for update)

@ciecierski ciecierski requested a review from abays May 14, 2026 11:42
@ciecierski ciecierski changed the title Inform user how to restore OLM CSV after cleanup with local web hook Inform developer how to restore OLM CSV after cleanup with local webhook May 14, 2026
abays
abays reviewed May 14, 2026
View reviewed changes
Comment thread hack/run_with_local_webhook.sh Outdated
@ciecierski
Inform developer how to restore OLM CSV on cleanup
5b092de 
Print a message in the cleanup handler with the exact `oc patch`
command needed to restore the operator's original CSV after the
local webhook run exits.
@ciecierski ciecierski requested review from abays and dprince May 14, 2026 19:30
abays
abays approved these changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label May 19, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, ciecierski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

@ciecierski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl-4-18 5b092de link unknown /test openstack-operator-build-deploy-kuttl-4-18

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ciecierski
Copy link
Copy Markdown
Contributor Author

ciecierski commented May 19, 2026

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abays abays abays approved these changes

@fultonj fultonj Awaiting requested review from fultonj

@rebtoor rebtoor Awaiting requested review from rebtoor

@dprince dprince Awaiting requested review from dprince

Assignees

@abays abays

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ciecierski @abays