Skip to content

Comments

Fix: Added customizable ansibleEE env ConfigMap name#1772

Open
oliashish wants to merge 2 commits intomainfrom
fix/configurable-envConfigMapName
Open

Fix: Added customizable ansibleEE env ConfigMap name#1772
oliashish wants to merge 2 commits intomainfrom
fix/configurable-envConfigMapName

Conversation

@oliashish
Copy link
Contributor

@oliashish oliashish commented Jan 22, 2026

Currently there is only one hardcoded string openstack-aee-default-env for ansibleEE environment variable, which is applied throughout the cluster.
This PR tries to let users ability to customize the ansibleEE env configMap for deployments levels individually. The precedence order for ansibleEEEnvConfigMap is deployment > default.
Not handling the case for nodeset level as the DeployOnAllNodeSet = true causes a conflict with job created for each nodeset.

Jira: OSPRH-18955

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d91bb4d5006d46cb8f53bf9db1e962da

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 12m 34s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 20s
cifmw-crc-podified-edpm-baremetal FAILURE in 48m 11s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 2h 56m 12s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 43m 43s

Currently there is only one hardcoded string `openstack-aee-default-env`
for ansibleEE environment variable, which is applied throughout the
cluser.
This PR tries to let users ability to customize the ansibleEE env
configMap for deployments and nodeset levels individually.
The precedence order for ansibleEEEnvConfigMap is deployment > nodeset >
default.
@oliashish oliashish force-pushed the fix/configurable-envConfigMapName branch from b1bf4a9 to 0822da4 Compare January 23, 2026 21:19
@oliashish oliashish changed the title WIP: added customizable ansibleEE env ConfigMap name Fix: Added customizable ansibleEE env ConfigMap name Jan 23, 2026
@oliashish oliashish requested a review from slagle January 23, 2026 21:30
@oliashish
Copy link
Contributor Author

/retest

@oliashish
Copy link
Contributor Author

/retest

@oliashish oliashish force-pushed the fix/configurable-envConfigMapName branch 2 times, most recently from d59ec54 to 7a69890 Compare February 18, 2026 08:07
@oliashish oliashish force-pushed the fix/configurable-envConfigMapName branch from 7a69890 to 2d66574 Compare February 18, 2026 12:11
@openshift-ci openshift-ci bot added the lgtm label Feb 18, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliashish, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rabi
Copy link
Contributor

rabi commented Feb 23, 2026

/test functional

@rabi
Copy link
Contributor

rabi commented Feb 23, 2026

/chery-pick 18.0-fr5

@rabi
Copy link
Contributor

rabi commented Feb 23, 2026

/cherry-pick 18.0-fr5

@openshift-cherrypick-robot

@rabi: once the present PR merges, I will cherry-pick it on top of 18.0-fr5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick 18.0-fr5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@oliashish
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 24, 2026

@oliashish: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl-4-18 2d66574 link true /test openstack-operator-build-deploy-kuttl-4-18

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants