Skip to content

Inherit top-level nodeSelector in remaining templates #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 14 commits into from
Nov 22, 2024
Merged

Inherit top-level nodeSelector in remaining templates #1200

openshift-merge-bot merged 14 commits into from
Nov 22, 2024

Conversation

@olliewalsh
Copy link
Contributor

@olliewalsh olliewalsh commented Nov 21, 2024

Jira: OSPRH-10734

@olliewalsh
Inherit top-level nodeSelector in dnsmasq, memcache, redis template
afeaf29
@olliewalsh
Inherit top-level nodeSelector in ironic template
e188670
@olliewalsh
Inherit top-level nodeSelector in manila template
32b232f
@olliewalsh
Inherit top-level nodeSelector in neutron template
63f23c9
@olliewalsh
Inherit top-level nodeSelector in ovn templates
2439aea
@olliewalsh
Inherit top-level nodeSelector in swift template
a77e2c6
@olliewalsh
Inherit top-level nodeSelector in telemetry template
33b160d
@olliewalsh
Inherit top-level nodeSelector in octavia template
5928a4c
@olliewalsh
Inherit top-level nodeSelector in rabbitmq template
d3045b1
@olliewalsh
Inherit top-level nodeSelector in openstackclient template
ffe39d5
@olliewalsh
Add functional tests for openstackclient and rabbitmq nodeSelector
9fc5731
@olliewalsh
Add kuttl test to catch any missing nodeSelectors
ab2a01f 
dnsmasq that is created by the kuttl tests and
ovn-controller-*-config is the only exception (sets a specific nodeName)
@olliewalsh
Update NodeSelector doc string
78c7700
@openshift-ci openshift-ci bot requested review from abays and slagle November 21, 2024 12:10
@olliewalsh olliewalsh requested a review from stuggi November 21, 2024 12:15
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 21, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f4999950066b44d3ac1eeb87c071f192

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 49s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 10m 12s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 20m 45s
❌ adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 1h 13m 59s
❌ openstack-operator-tempest-multinode FAILURE in 1h 18m 39s

stuggi
stuggi approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 22, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 48b09a8 into openstack-k8s-operators:main Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuggi stuggi stuggi approved these changes

@abays abays Awaiting requested review from abays

@slagle slagle Awaiting requested review from slagle

Assignees

@stuggi stuggi

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@olliewalsh @stuggi