[18.0-fr1] This patch allows Octavia to set its route annotations. #1194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends-On: openstack-k8s-operators/octavia-operator#438 Related-Issue: OSPRH-10959 (cherry picked from commit f91c5f8)
fernandoroyosanchez
force-pushed
the
10959fr1
branch
from
62e1f08 to
8811f38
Compare
Author
|
/retest |
Author
|
kuttl failing looks unrelated... |
fao89
approved these changes
Nov 20, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fao89, fernandoroyosanchez The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gthiemonge
reviewed
Nov 20, 2024
| github.com/openstack-k8s-operators/neutron-operator/api v0.5.1-0.20241112143215-294abc29ae85 | ||
| github.com/openstack-k8s-operators/nova-operator/api v0.5.0 | ||
| github.com/openstack-k8s-operators/octavia-operator/api v0.5.0 | ||
| github.com/openstack-k8s-operators/octavia-operator/api v0.5.1-0.20241119144914-248c7edb4442 |
Contributor
There was a problem hiding this comment.
shouldn't it be 0.5.0-something? how do we check that this version is the right one?
Author
There was a problem hiding this comment.
I get from:
froyo@fedora ~ $ go list -m -json github.com/openstack-k8s-operators/octavia-operator/api@18.0-fr1 | jq '.|"\(.Path) \(.Version)"'
"github.com/openstack-k8s-operators/octavia-operator/api v0.5.1-0.20241119144914-248c7edb4442"
openshift-merge-bot
bot
merged commit 8d3e3bc
into
openstack-k8s-operators:18.0-fr1
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On:
openstack-k8s-operators/octavia-operator#438
Related-Issue: OSPRH-10959
(cherry picked from commit f91c5f8)