Skip to content

Inherit top-level nodeSelector in placement, horizon, keystone template #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 3 commits into from
Nov 20, 2024
Merged

Inherit top-level nodeSelector in placement, horizon, keystone template #1188

openshift-merge-bot merged 3 commits into from
Nov 20, 2024

Conversation

@olliewalsh
Copy link
Contributor

@olliewalsh olliewalsh commented Nov 15, 2024 •
edited
Loading

@openshift-ci openshift-ci bot requested review from bshephar and slagle November 15, 2024 18:56
@olliewalsh olliewalsh mentioned this pull request Nov 16, 2024
Closed
gibizer
gibizer reviewed Nov 18, 2024
View reviewed changes
@gibizer
Copy link
Contributor

gibizer commented Nov 19, 2024

looks good, just the replace line needs to be removed

@olliewalsh olliewalsh force-pushed the placement_nodeselector branch from 6a79b0a to c818ef4 Compare November 19, 2024 17:56
@olliewalsh olliewalsh changed the title Inherit top-level nodeSelector in placement template Inherit top-level nodeSelector in placement, horizon, keystone template Nov 19, 2024
@olliewalsh olliewalsh requested a review from abays November 19, 2024 17:57
@olliewalsh olliewalsh mentioned this pull request Nov 19, 2024
Closed
abays
abays approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 19, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, olliewalsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olliewalsh
Copy link
Contributor Author

olliewalsh commented Nov 19, 2024

/test functional

@olliewalsh olliewalsh force-pushed the placement_nodeselector branch from c818ef4 to 30fddc4 Compare November 20, 2024 00:12
@openshift-ci openshift-ci bot removed the lgtm label Nov 20, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

New changes are detected. LGTM label has been removed.

@olliewalsh
Copy link
Contributor Author

olliewalsh commented Nov 20, 2024

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

@olliewalsh: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@olliewalsh
Copy link
Contributor Author

olliewalsh commented Nov 20, 2024

/test openstack-operator-build-deploy-kuttl

@olliewalsh olliewalsh force-pushed the placement_nodeselector branch from 30fddc4 to ef10439 Compare November 20, 2024 02:00
@openshift-ci openshift-ci bot removed the lgtm label Nov 20, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2024

New changes are detected. LGTM label has been removed.

@openshift-merge-bot openshift-merge-bot bot merged commit dfc0ead into openstack-k8s-operators:main Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gibizer gibizer gibizer left review comments

@stuggi stuggi stuggi left review comments

@abays abays abays approved these changes

@bshephar bshephar Awaiting requested review from bshephar

@slagle slagle Awaiting requested review from slagle

Assignees

@abays abays

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@olliewalsh @gibizer @abays @stuggi