Add GOWORK variable to the CI scripts #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
repos having go.work file checked in already adding |
The cinder-operator patch [1] introduces the 'go.work' file within the repository with the goal of automating the way we deal with multi module dependencies. However, the side effect of having a versioned 'go.work' in the repo is the failure of this script because GOWORK is automatically set to "on". This patch fixes the CI run on the cinder-operator PR [1], introducing a GOWORK variable (which is set to off by default) to make sure we can successfully run this check regardless of the Makefile approach. [1] openstack-k8s-operators/cinder-operator#79 Signed-off-by: Francesco Pantano <fpantano@redhat.com>
fmount
changed the title
fmount
changed the title
fmount
requested review from
Akrog and
dprince
and removed request for
dprince
Akrog
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cinder-operator patch [1] introduces the
go.workfile within the repository with the goal of automating the way we deal with multi module dependencies.However, the side effect of having a versioned
go.workin the repo is the failure of thegovetCI script becauseGOWORKis automatically set toon. This patch fixes the CI run on the cinder-operator PR [1], introducing aGOWORKvariable (which is set to off by default) to make sure we can successfully run this check regardless of the approach.The
GOWORKvariable value is also inherited from theMakefileof the project.[1] openstack-k8s-operators/cinder-operator#79
Signed-off-by: Francesco Pantano fpantano@redhat.com