Skip to content

DNM: test #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
olliewalsh wants to merge 3 commits into from
Closed

DNM: test #895

olliewalsh wants to merge 3 commits into from

Conversation

@olliewalsh
Copy link
Contributor

@olliewalsh olliewalsh commented Nov 18, 2024

@olliewalsh
Allow empty nodeSelector
3217501 
Switch to a pointer for nodeSelector to allow different logic for empty vs unset
@olliewalsh
Set nodeSelector on jobs/cronjobs
1d55c7c
@openshift-ci openshift-ci bot requested review from abays and jamepark4 November 18, 2024 08:43
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olliewalsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 18, 2024

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4973d52331334c8faab084f38a886347

✔️ openstack-meta-content-provider SUCCESS in 2h 44m 07s
✔️ nova-operator-kuttl SUCCESS in 43m 05s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 12m 47s
❌ nova-operator-tempest-multinode-ceph FAILURE in 1h 20m 45s

@olliewalsh
Pass-through empty nodeSelector to podSpecs
cc52c3d 
There is no need drop empty nodeSelector maps, omitempty already does this
@olliewalsh olliewalsh closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@olliewalsh