Propagate rabbitmq users to nova-cellX secret#1066
Propagate rabbitmq users to nova-cellX secret#1066openshift-merge-bot[bot] merged 2 commits intoopenstack-k8s-operators:mainfrom
Conversation
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/722fb15020ea48668696a9ea967e110c ❌ openstack-meta-content-provider FAILURE in 5m 20s |
lmiccini
force-pushed
the
cell_rmquser
branch
from
c90c928 to
710c405
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/66dd56c83809460ebc69b4bf475f3e32 ❌ openstack-meta-content-provider FAILURE in 12m 36s |
|
recheck |
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/openstack-operator#1797 is needed. |
|
recheck |
|
/test functional |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d61263831d4e40ac9dd1e74a07dae687 ✔️ openstack-meta-content-provider SUCCESS in 2h 47m 52s |
|
recheck |
|
/test functional |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/86da2905b79842218447638627e08de0 ✔️ openstack-meta-content-provider SUCCESS in 1h 05m 14s |
|
/test functional |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/075471792bbb4a00a30355133555361b ✔️ openstack-meta-content-provider SUCCESS in 3h 25m 02s |
|
/test functional |
1 similar comment
|
/test functional |
|
recheck |
| err := r.GenerateConfigs( | ||
| ctx, h, instance, configName, &hashes, templateParameters, map[string]string{}, cmLabels, map[string]string{}, | ||
| ctx, h, instance, configName, &hashes, templateParameters, extraData, cmLabels, map[string]string{}, | ||
| ) |
There was a problem hiding this comment.
without this PR
$ oc get secret nova-cell1-compute-config -o json | jq -r '.data | keys'
[
"01-nova.conf",
"nova-blank.conf"
]
with this PR - adds rabbitmq_user_name and notification_rabbitmq_user_name
$ oc get secret nova-cell1-compute-config -o json | jq -r '.data | keys'
[
"01-nova.conf",
"notification_rabbitmq_user_name",
"nova-blank.conf",
"rabbitmq_user_name"
]
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b0d14df9b3af4897ae7289bd9dc943c1 ✔️ openstack-meta-content-provider SUCCESS in 3h 07m 34s |
|
recheck |
lmiccini
force-pushed
the
cell_rmquser
branch
from
710c405 to
6870d95
Compare
lmiccini
force-pushed
the
cell_rmquser
branch
from
6870d95 to
b17ff68
Compare
|
/retest |
|
/test functional |
1 similar comment
|
/test functional |
lmiccini
force-pushed
the
cell_rmquser
branch
2 times, most recently
from
8f141f7 to
5c3b89b
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0e1e2cf439a54b4498b6b474b6beb516 ✔️ openstack-meta-content-provider SUCCESS in 2h 39m 45s |
|
/test functional |
1 similar comment
|
/test functional |
|
/test precommit-check |
lmiccini
force-pushed
the
cell_rmquser
branch
from
5c3b89b to
143f1e4
Compare
|
/lgtm |
|
I think this patch addresses [1], so +1 from me. (cc @SeanMooney) [1] #1052 (comment) |
|
#1052 (comment) for context |
|
|
||
| // Parse the INI file once after Eventually succeeds (avoids repeated parsing) | ||
| cfg, err := ini.Load([]byte(configData)) | ||
| Expect(err).ShouldNot(HaveOccurred(), "Should be able to parse config as INI") |
There was a problem hiding this comment.
this might bite us in the futre since the nova.conf is not an ini file its in oslo config format which is a superset fo ini format but htis is a prexisign test so its fine.
just noting tha twe cant assume its ini formce as its technially not even if they default config we generate is only useing the base feature of ini
| keystoneAPI := keystone.GetKeystoneAPI(novaNames.KeystoneAPIName) | ||
| keystoneAPI.Spec.Region = "regionOne" | ||
| Expect(k8sClient.Update(ctx, keystoneAPI)).To(Succeed()) | ||
|
|
There was a problem hiding this comment.
we might want to keep this in an Eventually bock.
There was a problem hiding this comment.
with that said i think this commit shoudl have been in a different pr
im happ to approve the priror commit but i think we had the ocnte in the eventually block becuase of ci issue in thepast with stablity on slow nodes so im concervitive with this type of refactor without review form others
|
i think we can proceed with this but i want @mrkisaolamb or @gibizer to take a look to confirm |
|
fwiw the tests optimization is a separate commit, so we could always revert it independently if we want to, or I can remove it now if you prefer. |
mrkisaolamb
left a comment
mrkisaolamb
left a comment
There was a problem hiding this comment.
Patch lgtm. I’m ok with having test improvements in the same PR since they are in a separate commit. Thanks @lmiccini and @SeanMooney !
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmiccini, mrkisaolamb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4ae0be0
into
openstack-k8s-operators:main
|
/cherry-pick 18.0-fr5 |
|
@lmiccini: new pull request created: #1071 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
Followup from #1052