refactor: use GetKeystoneAPIByName instead of label-based lookup#1011
refactor: use GetKeystoneAPIByName instead of label-based lookup#1011ratailor wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ratailor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/642ccde50be5416f89097693654d72cb ✔️ openstack-meta-content-provider SUCCESS in 2h 51m 01s |
4a0e940 to
333b27f
Compare
- Replace GetKeystoneAPI with GetKeystoneAPIByName in nova_controller.go - use instance.Spec.KeystoneInstance directly instead of empty label map - Remove TODO comment about changing the API usage. - Update keystone-operator/api dependency to support new functionality This provides a more direct and efficient way to get the KeystoneAPI resource by name rather then searching by labels. Commit message assisted by: claude-4-sonnet
333b27f to
42427a7
Compare
|
@ratailor: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0a37fc843d32461ba235d449e3a82130 ✔️ openstack-meta-content-provider SUCCESS in 2h 59m 48s |
This provides a more direct and efficient way to get the KeystoneAPI resource by name rather then searching by labels.
Commit message assisted by: claude-4-sonnet