Skip to content

Remove the old Ceph section from cinder.conf #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 23, 2023
Merged

Remove the old Ceph section from cinder.conf #115

openshift-merge-robot merged 1 commit into from
Jan 23, 2023

Conversation

@fmount
Copy link
Contributor

@fmount fmount commented Jan 20, 2023

This patch just removes the unused ceph section in cinder.conf.
The extraVolumes approach is used when cinder is configured with a Ceph backend, so this section is not required anymore.

Signed-off-by: Francesco Pantano fpantano@redhat.com

@openshift-ci openshift-ci bot requested review from Akrog and eharney January 20, 2023 10:44
@fmount fmount requested review from Akrog, abays and fultonj and removed request for Akrog and eharney January 20, 2023 10:44
fultonj
fultonj reviewed Jan 20, 2023
View reviewed changes
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind updating this PR to include updating the readme which still has cephBackend? Perhaps update it to have the new method. I could also take care of that in a follow up PR if you prefer to have two. Either way I agree we should have this change.

https://github.com/openstack-k8s-operators/cinder-operator/blob/7665a222fcfb6c869c202dc0805a3fd2f18dab70/README.md#configure-cinder-with-ceph-backend

@fmount
Remove the old Ceph section from cinder.conf
beaba3c 
This patch just removes the unused ceph section in cinder.conf. The
extraVolumes approach is used when cinder is configured with a Ceph
backend, so this section is not required anymore.

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@fmount
Copy link
Contributor Author

fmount commented Jan 20, 2023

Would you mind updating this PR to include updating the readme which still has cephBackend? Perhaps update it to have the new method. I could also take care of that in a follow up PR if you prefer to have two. Either way I agree we should have this change.

https://github.com/openstack-k8s-operators/cinder-operator/blob/7665a222fcfb6c869c202dc0805a3fd2f18dab70/README.md#configure-cinder-with-ceph-backend

I updated the Readme removing the old (and wrong) information. I added the reference to the Ceph secrets and extraMounts.
For the Readme, I think we should work on getting [1] merged to reflect the whole status of the operator.

[1] #77

fultonj
fultonj approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Francesco.

@openshift-ci openshift-ci bot added the lgtm label Jan 20, 2023
@fmount fmount requested a review from stuggi January 23, 2023 08:31
stuggi
stuggi approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, fultonj, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9f1a61c into openstack-k8s-operators:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fultonj fultonj fultonj approved these changes

@stuggi stuggi stuggi approved these changes

@abays abays Awaiting requested review from abays

@Akrog Akrog Awaiting requested review from Akrog

Assignees

@fultonj fultonj

@stuggi stuggi

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fmount @fultonj @stuggi @openshift-merge-robot