fix _user_data_change fails assertion after a soft clean

[pinikomarov]

Create infra can fail after a soft clean , on the '_user_data' assertion.

Resolves: https://issues.redhat.com/browse/OSPRH-22377

changing the assert to the expected result resolves the issue : 

      - _user_data_change is skipped or _user_data_change is not changed

Before: 

https://gitlab.cee.redhat.com/pkomarov/examples/-/jobs/43687373

 
TASK [config_drive : Assert we don't try to change an existing ISO that=['_meta_data_change is not changed', '_user_data_change is not changed', '_net_data_change is not changed'], msg=You're trying to edit an existing ISO. This isn't possible, since the ISO is usually attached to a virtual machine, and you cannot dynamically edit it.] ***Monday 24 November 2025 11:07:57 -0500 (0:00:00.196) 0:02:15.395 ******* task path: /home/zuul/src/github.com/openstack-k8s-operators/ci-framework/roles/config_drive/tasks/main.yml:81fatal: [localhost]: FAILED! => assertion: _user_data_change is not changed changed: false evaluated_to: false msg: You're trying to edit an existing ISO. This isn't possible, since the ISO is usually attached to a virtual machine, and you cannot dynamically edit it.
 

After: 

https://gitlab.cee.redhat.com/pkomarov/examples/-/jobs/43727490/raw

TASK [config_drive : Assert we don't try to change an existing ISO that=['_meta_data_change is not changed', '_user_data_change is skipped or _user_data_change is not changed', '_net_data_change is not changed'], msg=You're trying to edit an existing ISO. This isn't possible, since the ISO is usually attached to a virtual machine, and you cannot dynamically edit it.] ***
task path: /home/zuul/src/github.com/openstack-k8s-operators/ci-framework/roles/config_drive/tasks/main.yml:112
Tuesday 25 November 2025 04:43:43 -0500 (0:00:00.046) 0:02:14.465 ******
Tuesday 25 November 2025 04:43:43 -0500 (0:00:00.046) 0:02:14.465 ******
ok: [localhost] =>
changed: false
msg: All assertions passed

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eshulman2 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[danpawlik]

update commit message and add prefix:
[config_drive]

[hjensas]

I think we should do the same for _net_data_change - tasks "Generate user-data" and "Generate network-data" both use conditions like below, so both of should have the is skipped assert?

  when:
    - cifmw_config_drive_userdata is defined
    - cifmw_config_drive_userdata | length > 0

  when:
    - cifmw_config_drive_networkconfig is defined
    - cifmw_config_drive_networkconfig

Update, looks like | length > 0 on the cifmw_config_drive_networkconfig might make sense as well? But could do that in a separate PR?

[pinikomarov]

@hjensas while those suggestions may work , for the issues in this BZ they're not needed.
Currently I'm not at capacity to test them further and their implications thoroughly.

I suggest we merge the changes here as they are , since they'ew tested and analyzed,
and leave any subsequent changes in seperate PRs.

[hjensas]

Sure, but please do a follow up.

Will do follow up.

[hjensas]

We should to a follow up to address the same issue in the next assert.

[hjensas]

I created a follow up in: #3559

[danpawlik]

It breaks CI jobs. Let me try to fix, first. If not, let's revert.