[multiple] Move cifmw_basedir var to group_vars #3451
Conversation
|
Skipping CI for Draft Pull Request. |
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
danpawlik
force-pushed
the
OSPRH-20491-move-cifmw_data_dir
branch
from
24bfe97 to
214c377
Compare
danpawlik
changed the title
danpawlik
force-pushed
the
OSPRH-20491-move-cifmw_data_dir
branch
from
214c377 to
2290d71
Compare
danpawlik
requested review from
a team,
abays,
fmount and
fultonj
as code owners
|
Is there any possibility of encountering breaking errors when the cifmw_basedir is not defined? I see you mentioned there is cases where it is intentionally unset but how well are these cases handled? |
danpawlik
force-pushed
the
OSPRH-20491-move-cifmw_data_dir
branch
from
2290d71 to
5fe4d10
Compare
|
@brjackma if the var is not defined, it means the parent task/playbook needs to be changed. Ansible needs to read the group_vars. |
Pull request done just to verify all related PRs. Depends-On: openstack-k8s-operators#3451 Depends-On: openstack-k8s-operators#3454 Depends-On: openstack-k8s-operators#3455 Depends-On: openstack-k8s-operators#3456
|
recheck |
danpawlik
changed the title
danpawlik
changed the title
|
recheck |
danpawlik
force-pushed
the
OSPRH-20491-move-cifmw_data_dir
branch
from
d8ff45f to
9e962b7
Compare
danpawlik
force-pushed
the
OSPRH-20491-move-cifmw_data_dir
branch
from
9e962b7 to
2261ed4
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The `cifmw_basedir` variable is now expected to be defined group_vars. Previous fallback to `ansible_user_dir ~ '/ci-framework-data'` has been removed from playbooks and roles. This change ensures consistency across roles and prevents accidental use of a default path when `cifmw_basedir` is intentionally unset. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
The `cifmw_basedir` variable is now expected to be defined group_vars. Previous fallback to `ansible_user_dir ~ '/ci-framework-data'` has been removed from playbooks and roles. This change ensures consistency across roles and prevents accidental use of a default path when `cifmw_basedir` is intentionally unset. This commit is one of a set of changes. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
The `cifmw_basedir` variable is now expected to be defined group_vars. Previous fallback to `ansible_user_dir ~ '/ci-framework-data'` has been removed from playbooks and roles. This change ensures consistency across roles and prevents accidental use of a default path when `cifmw_basedir` is intentionally unset. This commit is one part of a set of changes. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
The `cifmw_basedir` variable is now expected to be defined group_vars. Previous fallback to `ansible_user_dir ~ '/ci-framework-data'` has been removed from playbooks and roles. This change ensures consistency across roles and prevents accidental use of a default path when `cifmw_basedir` is intentionally unset. This commit is one part of a set of changes. Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
danpawlik
force-pushed
the
OSPRH-20491-move-cifmw_data_dir
branch
from
2261ed4 to
b50d41c
Compare
|
recheck |
|
recheck |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4e16a13e256342f1a3087234447ad7ff ❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 100-0008119458 failed in 0s |
|
recheck |
|
recheck |
|
This PR is stale because it has been for over 15 days with no activity. |
4 participants
The
cifmw_basedirvariable is now expected to be defined group_vars.Previous fallback to
ansible_user_dir ~ '/ci-framework-data'has beenremoved from playbooks and roles.
This change ensures consistency across roles and prevents accidental use
of a default path when
cifmw_basediris intentionally unset.This commit is one part of a set of changes.
NOTE:
Probably this commit would be split into few pull requests.
More: OSPRH-20491
Depends-On: https://review.rdoproject.org/r/c/rdo-jobs/+/58488