-
Notifications
You must be signed in to change notification settings - Fork 144
Move cifmw_architecture_repo var to group_vars #3445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cifmw_architecture_repo var to group_vars #3445
Conversation
|
Skipping CI for Draft Pull Request. |
80913fb to
0151319
Compare
0151319 to
7dff01c
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/179225a458454813bc22d6f862784dd1 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 25s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3d97c0e7ad2b4e4cac787e0810f8ff68 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 21m 10s |
|
recheck |
abays
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally with HCI VA outside of Zuul CI context, and it succeeded.
/lgtm
fultonj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me.
f9a0f5a
7dff01c to
f9a0f5a
Compare
f9a0f5a to
1efd0dc
Compare
This commit is one of the steps of replacing common used vars with group_vars to improve overall maintenance of variables in ci-framework Signed-off-by: Amartya Sinha <amsinha@redhat.com>
1efd0dc to
73dfac3
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
recheck |
1 similar comment
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/51f77e9482bf4770bf4b6eddf237fe58 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 12m 51s |
|
recheck |
abays
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
fultonj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abays, fultonj The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
jokke-ilujo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit is one of the steps of replacing common used vars with group_vars to improve overall maintenance of variables in ci-framework
Depends-On: #3438