Skip to content

Conversation

@amartyasinha
Copy link
Contributor

@amartyasinha amartyasinha commented Oct 29, 2025

Since zuul ci playbooks won't read group_vars until it is upgraded, add the value of the var using defaults. It was missing only at a single place, so this should help.

Depends-On: #3438

…kuttl-tests.yml

Since zuul ci playbooks won't read group_vars until it is upgraded, add the value of the var using defaults. It was missing only at a single place, so this should help.

Signed-off-by: Amartya Sinha <amsinha@redhat.com>
@amartyasinha amartyasinha requested a review from a team as a code owner October 29, 2025 05:47
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

This change depends on a change that failed to merge.

Change #3438 is needed.

@amartyasinha
Copy link
Contributor Author

recheck

Copy link
Contributor

@danpawlik danpawlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is incorrect. If we move values to group_vars/all, such default vars should not be done anymore.

@amartyasinha
Copy link
Contributor Author

amartyasinha commented Oct 29, 2025

this is incorrect. If we move values to group_vars/all, such default vars should not be done anymore.

@danpawlik Yes, it makes sense, but since we have not merged the change which will ensure group_vars are read in ci/playbooks yet, we might need a way to provide the value of this var until that PR to include group_vars in ci/playbooks is merged or zuul is upgraded..

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ab9e062da65d4557bdfaea0242164c59

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 40s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 34s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 22s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 05s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 50s
cifmw-multinode-kuttl RETRY_LIMIT in 5m 29s
✔️ build-push-container-cifmw-client SUCCESS in 19m 13s

@amartyasinha
Copy link
Contributor Author

recheck

@evallesp
Copy link
Contributor

evallesp commented Nov 6, 2025

this is incorrect. If we move values to group_vars/all, such default vars should not be done anymore.

@danpawlik Yes, it makes sense, but since we have not merged the change which will ensure group_vars are read in ci/playbooks yet, we might need a way to provide the value of this var until that PR to include group_vars in ci/playbooks is merged or zuul is upgraded..

Would it make sense to add a comment there to remove then?

@amartyasinha amartyasinha deleted the install_yamls_missing_group_vars branch January 9, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants