-
Notifications
You must be signed in to change notification settings - Fork 144
Add default cifmw_installyamls_repos value in ci/playbooks/kuttl/run-kuttl-tests.yml #3439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default cifmw_installyamls_repos value in ci/playbooks/kuttl/run-kuttl-tests.yml #3439
Conversation
…kuttl-tests.yml Since zuul ci playbooks won't read group_vars until it is upgraded, add the value of the var using defaults. It was missing only at a single place, so this should help. Signed-off-by: Amartya Sinha <amsinha@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This change depends on a change that failed to merge. Change #3438 is needed. |
|
recheck |
danpawlik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is incorrect. If we move values to group_vars/all, such default vars should not be done anymore.
@danpawlik Yes, it makes sense, but since we have not merged the change which will ensure group_vars are read in ci/playbooks yet, we might need a way to provide the value of this var until that PR to include group_vars in ci/playbooks is merged or zuul is upgraded.. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ab9e062da65d4557bdfaea0242164c59 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 40s |
|
recheck |
Would it make sense to add a comment there to remove then? |
Since zuul ci playbooks won't read group_vars until it is upgraded, add the value of the var using defaults. It was missing only at a single place, so this should help.
Depends-On: #3438